The safety policy hands off a Shopify order note as "moving money" while refunds pass
維護者通常 1 天內回覆
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 48/100
- Issue 類型
- 缺陷
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- typescript
研究方向
Start with the payments rule in server/src/approvals/policy.ts and trace how the safety policy evaluates Shopify action names, descriptions, and arguments. Check how SHOPIFY_UPDATE_ORDER and SHOPIFY_CREATE_REFUND are represented and covered by existing tests. Done means notes on an order no longer trigger a money hand-off while refunds do; the proposed administrator allow rule is an additional design question.
由索引模型根據 Issue 內容生成。
描述
What happens
Writing a note on a Shopify order (SHOPIFY_UPDATE_ORDER with only id and note) is handed off to the person as a money action:
approval.evaluated composio-shopify/SHOPIFY_UPDATE_ORDER
outcome: { behaviour: "hand_off", source: "safety",
reason: "Paying, purchasing or moving money is always done by the person." }
Meanwhile SHOPIFY_CREATE_REFUND, which does move money, passes without a hand-off.
The payments rule in server/src/approvals/policy.ts is a keyword regex (payment|pay|checkout|purchase|place order|... |billing). The order-update action's schema or description very likely matched on a word such as billing (it has a billing_address field), while "refund" is not in the list at all.
Suggested fix
- Classify on what the action does, not on words found anywhere in its schema. At least match against the action's name and the arguments actually sent, not field names that were left empty.
- Add refunds to the money rule (
refund,create_refund), since they move money. - Consider letting an administrator mark a specific action as not money-moving (an allow rule that the safety layer respects), with the decision recorded in the audit log.
- 主要語言
- TypeScript
- 星號
- 7.1k
- 分支
- 962
- 平均合併
- 1 天 7 小時
- 30 天內合併 PR
- 143
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 沒有貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
CopilotKit/OpenBot 的其他 Issue
-
Composio plugin sends x-api-key, but connect.composio.dev/mcp requires x-consumer-api-key可能已有人在做 @azmi2409 於 3 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 78/100
CopilotKit/OpenBot#817 · 2 則留言 ·
維護者通常 1 天內回覆
-
Wrong key location at startup可能已有人在做 @charan-rathore 於 13 天前認領。 未關閉
難度 1/5 1 小時以內 新手友好度 68/100
CopilotKit/OpenBot#800 ·
維護者通常 1 天內回覆
-
setup-learning.ts fails on Windows with "spawn npx.cmd EINVAL"可能已有人在做 @Caldas 於 16 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 80/100
CopilotKit/OpenBot#792 ·
維護者通常 1 天內回覆
-
حفض未關閉
難度 5/5 一週以上 新手友好度 10/100
CopilotKit/OpenBot#911 ·
維護者通常 1 天內回覆
-
難度 4/5 3-5 天 新手友好度 35/100
CopilotKit/OpenBot#897 ·
維護者通常 1 天內回覆
查看 CopilotKit/OpenBot 的全部 Issue
相似的 Issue
-
area:cli bug P4
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
bug from-studio
難度 2/5 1-3 小時 新手友好度 65/100
esengine/DeepSeek-Reasonix#14868 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 82/100
linxiv-dev/linXiv#384 · 1 則留言 ·
維護者通常 1 天內回覆
-
scope:core type:security
難度 2/5 1-3 小時 新手友好度 75/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 66/100
mailgun/mailgun.js#544 ·