Stuck "drop to attach" overlay never clears after orphaned drag session, pegs renderer CPU

未關閉
#915 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
52/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
electron
領域
desktop

研究方向

The issue identifies app-level drag handlers and an Electron session/webContents watchdog as possible entry points; inspect how drag state is cleared for drop, dragleave, dragend, blur, and Escape. Reproduce by killing the drag source mid-drag, then verify the overlay clears, the renderer no longer spins, and normal drag completion still works.

由索引模型根據 Issue 內容生成。

描述

Summary

If a drag session hovering over the window is interrupted, the drag source process exits before dragleave / drop fires, the app stays permanently stuck in the "drop to attach" receiving state. The overlay cannot be dismissed, and the renderer spins at ~50% CPU indefinitely while stuck.

Expected Behavior

  • The drop overlay should clear when a drag ends by any means: drop, dragleave, dragend, window blur, or Escape.
  • Orphaned drags (source process gone, so no terminal drag event will ever arrive) should be handled with a timeout or an active-drag-session check so the UI cannot get stuck indefinitely.
  • A stuck overlay must not spin the renderer: animations/repaint loops should pause when there is no active drag, and any "is a drag active?" state should have a watchdog/reset path.

Actual Behavior

  • Overlay persists across window focus/blur changes.
  • Escape does not dismiss it.
  • Clicking through it works, the underlying UI remains interactive, but the overlay stays on top, obscuring content.
  • The overlay clears only on a full window reload (Cmd+R), and only when the app is explicitly frontmost (a Cmd+R keystroke sent while another app is frontmost goes to that app, so the first attempt silently did nothing).
  • The renderer process pegged at ~50–66% CPU the entire time it was stuck.

Sample of the stuck renderer main thread (PID 79476, sample 79476 2), taken while the overlay was stuck, main thread continuously busy in the Electron/V8 event loop rather than idle:

Thread_19701920  DispatchQueue_1: com.apple.main-thread (serial)
  ElectronMain (Electron Framework)
    ... v8::internal::compiler::CompilationDependencies::RecordDependency
        mach_msg (libsystem_kernel.dylib)   <- 786/1129 samples

CPU trend across the stuck period (renderer PID never changed, confirming no reload occurred):

51% -> 66% -> 37% (after attempted Cmd+R, PID unchanged) -> 66% -> 54% -> 33%

Renderer was in state R/S at 30–66% continuously while the app was otherwise idle.

Steps to reproduce the issue

  1. Start dragging an icon from another app over the Command Code window.
  2. Kill the drag source process mid-drag, so neither drop nor dragleave ever fires on our side.
  3. The overlay remains visible indefinitely, as if an item is still being held over the window.

In our incident the dragged item was an Activity Monitor icon and the source was gone by the time we investigated (Activity Monitor absent from ps output entirely), so the drag had become fully orphaned at the WindowServer level.

Command Code Version

0.1.37 (CFBundleShortVersionString)

Operating System

macOS 27.0, build 26A428 (macOS Tahoe generation), on 10-core Apple Silicon with 64 GB RAM

Terminal/IDE

N/A, Electron desktop app

Shell

N/A, no shell involved in this issue

Session file

None attached

Fix prompt

None

Additional context

Reproduced alongside an orphaned WindowServer drag image (the drag source dying mid-drag is part of the setup).

The orphaned drag also left a ghost drag image floating above all windows, which survived killall Dock, killall Finder, killall WindowManager, and killall SystemUIServer, and was not captured by screencapture. That artifact itself is an Apple-side WindowServer issue and is not filed against this repo, noting it only because the app-side stuck overlay and the system-side ghost image are two symptoms of the same orphaned drag event.

Open questions for maintainers:

  • Confirm Cmd+R behavior on other platforms (Windows/Linux), the "must be frontmost" part may be macOS System Events-specific to our keystroke injection rather than an app bug.
  • Decide whether the fix belongs in app-level drag handlers, an Electron session/webContents watchdog, or both.
  • Consider whether the same watchdog should log drag-state transitions (would have made this incident much faster to diagnose).

Automated posting by agentic team with human oversight.

主要語言
沒有語言資料
星號
4k
分支
350
PR 合併指標
30 天內沒有已合併 PR

貢獻指南

這個儲存庫沒有索引到貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

CommandCodeAI/command-code 的其他 Issue

查看 CommandCodeAI/command-code 的全部 Issue

相似的 Issue

更多 Desktop Dev Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。