Action Scheduler queue cleanup fatals with "Unidentified action" after concurrent deletion
評估
這個 Issue 還沒有評估資料。
描述
Summary
Visualizer's scheduled-action cleanup can terminate with an uncaught InvalidArgumentException when an action selected for failure processing is deleted or otherwise disappears before its status update. Cleanup is expected to tolerate that race and continue processing the queue; instead, the request ends in a fatal error. This can interrupt scheduled work on an affected site.
Customer context
- Product / area: Visualizer scheduled database refresh / bundled Action Scheduler
- Version: 4.0.7
- Environment: WordPress site; PHP, WordPress, database, and hosting versions were not provided
- Integration / third party: Bundled
woocommerce/action-scheduler3.9.3 - Reported error / symptom: One captured uncaught
InvalidArgumentExceptionstates that an action could not be marked failed because another process may have deleted it - Impact: One queue-cleanup request terminated; broader scheduling impact is unknown
Reproduction notes
Runtime reproduction was not performed. Evidence-backed inferred workflow:
- Run Visualizer 4.0.7 with its bundled Action Scheduler active.
- Have queue cleanup query a stale action in
in-progressstatus. - Between that query and the status update, let another process delete the action or alter it so the update affects no row.
- Observe an uncaught
InvalidArgumentExceptionfromActionScheduler_DBStore::mark_failure().
The submitted crash log confirms steps 2–4 occurred on one site, but it does not identify the competing process or action hook.
Diagnosis
Conclusion
The fatal is confirmed as a dependency race exposed by Visualizer's bundled Action Scheduler. The captured stack shows ActionScheduler_QueueCleaner::mark_failures() selecting an action and ActionScheduler_DBStore::mark_failure() throwing when the subsequent database update affects no row. Inspection confirms that the cleaner does not handle that exception. Upstream issue woocommerce/action-scheduler#970 describes the same fatal, remains open, and is labeled as a high-priority bug.
Where this likely occurs
- Scheduled database-refresh subsystem:
classes/Visualizer/Module/Setup.php—Visualizer_Module_Setup::schedule_refresh_db_action()lines 486–504 schedules thevisualizer_schedule_refresh_dbrecurring action through Action Scheduler when its API is available. - Dependency bootstrap:
index.php— Visualizer startup callback approx. lines 148–157 loads the bundled Action Scheduler entry point. - Dependency selection:
composer.lock— package record lines 181–221 lockswoocommerce/action-scheduler3.9.3 at commitc58cdbab17651303d406cd3b22cf9d75c71c986c; tagv4.0.7contains this lock. - Queue-cleanup path:
vendor/woocommerce/action-scheduler/classes/ActionScheduler_QueueCleaner.php—ActionScheduler_QueueCleaner::mark_failures()lines 206–228 queries stale running action IDs and callsmark_failure()for each without an exception boundary. - Data-store path:
vendor/woocommerce/action-scheduler/classes/data-stores/ActionScheduler_DBStore.php—ActionScheduler_DBStore::mark_failure()lines 1215–1233 throws the reported exception when its update affects no row. - Git history: Visualizer commit
bc14d4b8introduced the Action Scheduler dependency and loading path; it is present fromv4.0.0throughv4.0.7. This identifies the feature boundary but does not prove a regression because the earlier releases did not provide the same scheduler workflow.
Engineering notes
Visualizer loads its packaged Action Scheduler conditionally and uses the global as_* API. On sites with multiple Action Scheduler copies, normal package version arbitration may determine which copy executes; the crash path identifies a copy under Visualizer's packaged vendor/woocommerce/action-scheduler directory. The race window lies between querying stale running actions and updating each action, so concurrent cleanup, deletion, or another process changing the row can trigger it. The exact action hook and the process that removed or changed the reported row are unknown.
Test coverage status
No relevant Visualizer unit or e2e coverage was found during inspection for Action Scheduler cleanup, concurrent action deletion, or mark_failure() exceptions. The upstream dependency's test suite was not available in the Visualizer checkout.
What to verify or explore next
- May be worth reproducing with Visualizer 4.0.7 by placing an action in stale
in-progressstate, deleting or changing it after the cleaner query, and running queue cleanup. - If reproducible, checking both WP-Cron and asynchronous queue-runner cleanup contexts may establish the affected execution surfaces.
- May be worth confirming behavior when another active plugin registers a newer or older Action Scheduler copy before Visualizer.
- Checking the packaged release ZIP can confirm that its dependency source exactly matches lock reference
c58cdbab17651303d406cd3b22cf9d75c71c986c.
Unknowns / follow-up
The report contains one occurrence and no site load, database, concurrency, or action-hook details. It is unknown whether the vanished action belonged to Visualizer or another component sharing the scheduler tables.
Confidence
Confidence: 94/100
The captured stack exactly matches a documented race in the Action Scheduler dependency bundled by Visualizer 4.0.7, and repository inspection confirms that the exception from mark_failure() is not handled by the queue cleaner. Upstream issue woocommerce/action-scheduler#970 independently classifies the same fatal as a bug; no matching Visualizer issue was found.
Source: automated uninstall feedback — visualizer, 2026-08-30
Generated by bug-report-triage (ID: bug-report-triage_6a950a8cd8e195.34071552)
- 主要語言
- PHP
- 星號
- 108
- 分支
- 29
- 平均合併
- 3 天 13 小時
- 30 天內合併 PR
- 8
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
Codeinwp/visualizer 的其他 Issue
-
feature-request-triage
難度 4/5 3-5 天 新手友好度 64/100
Codeinwp/visualizer#1388 ·
-
Add a Default value for font settings可能重新可做 關聯的 PR 已關閉且未合併。 未關閉
難度 2/5 1-3 小時 新手友好度 25/100
Codeinwp/visualizer#1111 ·
-
customer report doc-needed new feature
難度 5/5 一週以上 新手友好度 35/100
Codeinwp/visualizer#1058 · 4 則留言 ·
-
question
難度 5/5 一週以上 新手友好度 15/100
Codeinwp/visualizer#1024 · 1 則留言 ·
-
new feature
難度 5/5 一週以上 新手友好度 25/100
Codeinwp/visualizer#1002 ·
查看 Codeinwp/visualizer 的全部 Issue
相似的 Issue
-
難度 1/5 1 小時以內 新手友好度 76/100
majorsilence/Reporting#493 ·
維護者通常 1 天內回覆
-
Bug
難度 2/5 1-3 小時 新手友好度 77/100
Automattic/safe-publish#764 ·
維護者通常 1 天內回覆
-
sync-en
難度 2/5 1-3 小時 新手友好度 75/100
維護者通常 1 天內回覆
-
sync-en
難度 1/5 1-3 小時 新手友好度 84/100
維護者通常 1 天內回覆
-
Перевод устарел
難度 2/5 1-3 小時 新手友好度 68/100