Chat says it's only available in a lobby while you're in one (late leave answer tears down the new lobby)

已關閉
  • 哪裡不對？
#47 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 2 天內回覆

已經有一個關聯 PR 被合併了。

  • #48 來自 @Jr-JoshS —— 已合併

評估

難度
3/5
預估耗時
1-2 天
新手友好度
25/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
lua
領域
api, networking

研究方向

The bug is in the teardown run by lobby:leave() when the lobby_leave RPC callback arrives late. Start with the callback and the cleanup functions it calls: L.cleanup, MPAPI.chat.cleanup(), nakama_lobby.forget() and on_lobby_disconnected(). Done means a late leave answer no longer affects a lobby the player has since joined, which you can check by delaying the callback and confirming chat, match updates and the lobby page still work. Open PR #48 already targets this, so coordinate with its author before starting.

由索引模型根據 Issue 內容生成。

描述

Reported in #bugs-and-issues: "I am in a game and it shows this" — [MultiplayerAPI] Chat is only available while in a lobby.

Why: lobby:leave() tears the lobby down in the lobby_leave RPC's callback. If that answer comes after the player is already in another lobby (left and quickly created, joined or got matched into a new one), the old lobby's L.cleanup runs against the new one:

  • MPAPI.chat.cleanup() switches chat off, so typing in the new lobby shows the message above.
  • nakama_lobby.forget() drops the new lobby's match, so it stops getting lobby updates (its host never sees the next player join).
  • on_lobby_disconnected() sends the player back to the mod menu while they are still in the new lobby.

To reproduce: delay the lobby_leave callback by ~3s (a slow answer), leave a lobby and create a new one right away. Once the late answer lands: chat is off, the host doesn't see a player who joins, and the lobby page is replaced by the mod menu.

Reproduced with two clients on a local server.

主要語言
Lua
星號
10
分支
8
平均合併
1 天 18 小時
30 天內合併 PR
20

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

Balatro-Multiplayer/BalatroMultiplayerAPI 的其他 Issue

查看 Balatro-Multiplayer/BalatroMultiplayerAPI 的全部 Issue

相似的 Issue

更多 Lua Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。