JSON union reader checks only the last unknown field, so field order decides
維護者通常 3 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Start in core/src/main/java/com/backblaze/b2/json/B2JsonUnionBaseHandler.java. Read the read loop around line 350, where unknownFieldNameOrNull is overwritten on each unknown field, and the check after the loop around line 384. Add a test that deserializes an object with two unknown fields in both orders under ERROR mode, with a discard list, and confirm the outcomes differ. It is done when both orders give the same, correct result and the test passes.
由索引模型根據 Issue 內容生成。
描述
What happens
While reading a union object with ExtraFieldOption.ERROR, each unknown field overwrites a single unknownFieldNameOrNull variable, and only the last one is checked against the fields that may be discarded. If an object has two unknown fields, a non-discardable unknown field that comes before a discardable one is accepted, so the result depends on field order.
Where
core/src/main/java/com/backblaze/b2/json/B2JsonUnionBaseHandler.java:350 (assignment in the read loop) and :384 (the check after the loop).
Why it matters
Impact: Wrong request or result (an unknown field is accepted that should be rejected), silent when accepted. Severity: Medium, because it needs ERROR mode, a discard list and two or more unknown fields (unusual), and the SDK's own responses are read in the lenient mode.
How to check
Found by reading the code, not reproduced. Read the loop and the check after it. A test could deserialize {"type":"x","bad":1,"discardable":2} and the same object with the two fields swapped, with ERROR mode, and compare the outcomes. Collecting all unknown names, or checking each one as it is read, would fix it.
Version
Seen at v6.5.0. Present on the default branch: present.
- 主要語言
- Java
- 星號
- 103
- 分支
- 23
- 平均合併
- 5 天 8 小時
- 30 天內合併 PR
- 3
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
Backblaze/b2-sdk-java 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
Backblaze/b2-sdk-java#248 ·
維護者通常 3 天內回覆
-
難度 2/5 1-3 小時 新手友好度 74/100
Backblaze/b2-sdk-java#247 ·
維護者通常 3 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
Backblaze/b2-sdk-java#246 ·
維護者通常 3 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
Backblaze/b2-sdk-java#245 ·
維護者通常 3 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
Backblaze/b2-sdk-java#242 ·
維護者通常 3 天內回覆
查看 Backblaze/b2-sdk-java 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
IETF-Hackathon/pqc-certificates#351 ·
維護者通常 2 天內回覆
-
hermes-queue
難度 2/5 1 小時以內 新手友好度 72/100
chrisalunlloyd2-sudo/mindpalace#393 ·
維護者通常 1 天內回覆
-
core-types enhancement good first issue
難度 2/5 1-3 小時 新手友好度 85/100
higher-kinded-j/higher-kinded-j#1509 ·
維護者通常 1 天內回覆
-
bug(core): skip_nodes.json is missing SELECT and PRE, causing Python and Java to insert separators into dropdown options and preformatted text可能已有人在做 @Bhumit267 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 85/100
維護者通常 1 天內回覆