Distinguish "node" and "state"

未關閉
#102 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 3 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
25/100
Issue 類型
重構
描述清晰度
基本清楚
活躍度
停滯
技術堆疊
typescript
領域
frontend

研究方向

The payload names no specific files, so start by searching the TypeScript source for uses of "state" that mean the circles of the diagram and their data, and separate them from uses that mean application state. Before editing, check with the maintainers how to split the rename into small pull requests to avoid merge conflicts, since the issue itself warns about that. Done means the diagram-element terminology is consistent and the existing tests still pass.

由索引模型根據 Issue 內容生成。

描述

discussion needed refactor

The terms "node" and "state" are often used interchangeably in the code to refer to the circles in a state diagram connected by transitions, and the data they represent. Lately, I've taken to using the term "node" for these, as it's a bit more explicit, and using "state" to refer to the state of the app itself.

Doing this refactor would likely cause changes in a lot of files, so it would need to be carefully planned to avoid a bunch of merge conflicts.

It may be important to consider that "node" is also a term that refers to elements in the DOM tree as well as the Node.js framework. I don't think these will cause naming conflicts, but it may still be good to keep in mind?

主要語言
TypeScript
星號
1
分支
23
平均合併
3 天 15 小時
30 天內合併 PR
9

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

AutomatonBuilderGUI/AutomatonBuilderGUI 的其他 Issue

查看 AutomatonBuilderGUI/AutomatonBuilderGUI 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。