ArduPilot/ardupilot

MAVlink library prevents OSD from receiving RSSI from 3DR modems

Open

#5,275 建立於 2016年11月25日

在 GitHub 查看
 (6 留言) (0 反應) (1 負責人)C++ (9,336 star) (15,603 fork)batch import
EnhancementLibraryMAVLinkgood first issue

描述

Issue details

file https://github.com/ArduPilot/ardupilot/blob/master/libraries/GCS_MAVLink/MAVLink_routing.cpp

lines starting 103

if (msg->msgid == MAVLINK_MSG_ID_RADIO ||
        msg->msgid == MAVLINK_MSG_ID_RADIO_STATUS) {
        // don't forward RADIO packets
        return true;
    }

this code fully filters out MAVLINK_MSG_ID_RADIO_STATUS and MAVLINK_MSG_ID_RADIO messages so no one module (and OSD too) can't see RSSI from 3DR modems.

So in Copter 3.1 3DR RSSI is working, and definitely not working on Copter 3.3/3.4. All OSD users logically consider that it is problem of OSD itself

This messages should be filtered out only on port from which they are comes, and be routed to all another MAVlink ports. Or even better to route this message to all ports and filter them out in 3DR modem firmware.

貢獻者指南

技術棧
cpp
領域
backendapi
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C++ basicsMAVLink protocolArduPilot build setup
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue is in MAVLink routing.cpp at line 103, where RADIO and RADIO STATUS messages are fully filtered out. The fix should either forward these messages to all other MAVLink ports or filter them only on the incoming port. A newcomer should study the routing logic in that file and implement a change that allows these messages to reach other modules like OSD while maintaining appropriate filtering on the modem port.
MAVlink library prevents OSD from receiving RSSI from 3DR modems · ArduPilot/ardupilot#5275 | Good First Issue