ArduPilot/ardupilot

Rover: Guided mode's wp_bearing is incorrect for some sub modes

開放

#11,284 建立於 2019年5月7日

 (3 則留言) (0 個反應) (0 位負責人)C++ (15,603 個分叉)batch import
BUGRovergood first issue

倉庫指標

星標
 (9,336 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

While working on this PR: https://github.com/ArduPilot/ardupilot/pull/11283 I found that Guided mode's wp_bearing valueis incorrect for some submodes.

Guided uses the mode.cpp's wp_bearing method which calls the navigation library. This works when _guided_mode == Guided_WP but is incorrect when it's Guided_HeadingAndSpeed, Guided_TurnRateAndSpeed and Guided_Loiter.

We should override the wp_bearing for Guided mode and then handle these other sub modes. For example, for Guided_HeadingAndSpeed we should use the target heading. For Guided_TurnRateAndSpeed we should return 0.0f. For Guided_Loiter we should call ModeLoiter's wp_bearing.

貢獻者指南