CONTRIBUTING.md and CI run scripts/runs/tests_for.py, which is not in the repository

Open Beginner friendly
#875 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

@serafimcloud is already working on this.

Since Nov 17, 2026.

  • #876 by @advenimus — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
74/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Active
Tech stack
github-actions, swift

Research direction

Start with CONTRIBUTING.md’s “Tests and checks” section and compare its tests_for.py command with the test suites available in the repository. Update the guide to explain how to run and find several suites with Swift’s --filter, as proposed in the issue. Done when the documented commands no longer rely on the missing script and clearly show how to run relevant suites.

Written by the indexing model from the issue text.

Description

Annoying in progress
Yab version

Source at main (0.47.19). Not about the app: CONTRIBUTING.md and CI.

Device

Mac, Apple silicon

macOS or iOS version

macOS 27.2.1

Engine of the tab

Not about a page

Area

Something else

Steps to reproduce
  1. Clone the repository and follow "Tests and checks" in CONTRIBUTING.md.
  2. Run the first row of the table: swift test --filter "$(scripts/runs/tests_for.py)".
What you expected

The suites that cover the files I changed run.

What happened instead

scripts/runs/tests_for.py is not in the repository. The shell says no such file or directory: scripts/runs/tests_for.py and the filter comes out empty.

Searched: no file named tests_for (or anything else that picks suites from changed files) in the tree or in any commit of the public history. scripts/runs/ holds build_cache.py, deferred_qa.py and power.sh. The script is named in CONTRIBUTING.md, .github/workflows/ci.yml, docs/page-engine.md, YabCore/Navigation.md and the evals/chromium-drm/*.sh farm jobs. docs/open-source/sync.md says each sync leaves out the paths in exclude.txt, which is not public either, so I assume it was left out on purpose, like ./farm.

CI is affected too: the "Suites for the changed files" step runs python3 scripts/runs/tests_for.py --since "$base" 2>/dev/null. The error is discarded, the filter is empty, and the step prints suites: none and "Nothing narrower than the whole suite matched; the full-suite job covers it." and passes. That is what the main run for #188 printed (run 43745327192), so that step runs no tests on any pull request today, though the comment above it and CONTRIBUTING.md ("run the suites for what you changed, as CI does") say it does.

How often

Every time

Did it work before? (optional)

No, never

Proposed fix

The guide stops naming the script and says how to run and find several suites with --filter (pull request to follow). Whether to publish tests_for.py or change the CI step is a maintainer's call, so the pull request leaves ci.yml alone.

Dominant language
Swift
Stars
648
Forks
56
Avg merge
21h 14m
Merged PRs (30d)
22

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from yetanotherbrowser/yab

All issues in yetanotherbrowser/yab

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.