The web exact-test inputs stay enabled when the exact checkbox is off and show errors only in the results area
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- html, javascript
- Domain
- accessibility, frontend, testing
Research direction
Read profiler.html, assets/profiler-ui.js and assets/profiler-compare.js, then follow the keywords box wiring in issue #889 and the related work in #925. Check how the exact checkbox controls Shuffles and Row cap, and how invalid values are reported. Done when both inputs are disabled until Exact test is checked, invalid values are announced beside their inputs with aria-invalid, and the wiring is tested.
Written by the indexing model from the issue text.
Description
Where: profiler.html, assets/profiler-ui.js and assets/profiler-compare.js (#925).
Current gap: the Shuffles and Row cap inputs sit beside the exact checkbox but are always editable, so values typed with the box unticked are silently ignored; and an invalid value (0, 1.5, a million and one) is reported as a paragraph in the proxy results rather than on the input, so a screen-reader user who is on the input hears nothing.
Repro: on profiler.html type abc into Shuffles with "Exact test" unticked, run the proxy check: no error and no effect; tick it and run again: the error appears far from the field.
Suggested approach: disable both inputs until the checkbox is ticked, set aria-invalid and a linked role="alert" message beside the field (like the keywords box, #889) instead of the results-area paragraph, and test the wiring.
- Dominant language
- HTML
- Stars
- 47
- Forks
- 45
- Avg merge
- 2h 54m
- Merged PRs (30d)
- 59
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from yakew7/Fair-Code
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
All issues in yakew7/Fair-Code
Similar issues
-
16 slate buttons are unreadable in the light theme (dark text on dark grey)Possibly taken A pull request linked to this issue is open or already merged. Openbug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
vavallee/bindery#3241 · 1 comment ·
Maintainers usually reply within 1 day
-
Connected devices: the "more" (three dots) button of each device has no accessible name on mobileOpenai-driven-qa bug Minor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
linagora/cozy-settings#873 ·
-
area/accessibility
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 7 days
-
Library Add Content buttons and preview-changes actions are identifiable only by label or positionOpena11y bug
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
openedx/frontend-app-authoring#3309 ·
Maintainers usually reply within 1 day
-
[Bug]: EventCard crashes on missing tags and is keyboard inaccessiblePossibly taken @Senthil455 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Harsh-vardhan09/AthLead#296 · 4 comments ·
Maintainers usually reply within 1 day