--csv-bom was never wired up: PR #850 added an unused helper parameter, so #846 is not fixed
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
Research direction
Start in faircode/cli.py: look at _write_csv_export and the argument parsers for profile and compare, where --csv and --csv-provenance are already defined. Add a --csv-bom flag that requires --csv and passes bom=args.csv_bom at both call sites. Done when --csv-bom is accepted, the written file starts with bytes \xef\xbb\xbf, and the README and SPEC.md section 12 describe the flag.
Written by the indexing model from the issue text.
Description
Where: faircode/cli.py (_write_csv_export, the profile/compare argument parsers).
Current gap: PR #850 ("Add --csv-bom option for Excel compatibility", addressing #846) only added a bom=False parameter to _write_csv_export(). No --csv-bom argument was ever added to the parsers and no caller passes bom, so the code path is dead and #846 (Excel on Windows garbling non-ASCII labels in --csv exports) is not actually fixed, even though it was closed.
Repro:
$ python3 -m faircode profile data.csv --csv out.csv --csv-bom
faircode: error: unrecognized arguments: --csv-bom
$ grep -n "bom" faircode/cli.py
(only the unused helper parameter)
Suggested approach: add --csv-bom to both profile and compare, pass bom=args.csv_bom at the two _write_csv_export call sites (it needs --csv, like --csv-provenance), document it in the README and SPEC.md section 12, and test that the file starts with \xef\xbb\xbf and that stdout output starts with U+FEFF.
- Dominant language
- HTML
- Stars
- 47
- Forks
- 45
- Avg merge
- 3h 12m
- Merged PRs (30d)
- 77
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from yakew7/Fair-Code
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Numeric column headers keep their type in Python (the integer 2020) and are text in the web enginePossibly taken @snehal1931 claimed this 3 days ago. Openbug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
yakew7/Fair-Code#1045 · 2 comments ·
Maintainers usually reply within 1 day
-
JSON string cells "NA" and "" are missing in the web engine and ordinary values in PythonPossibly taken @snehal1931 claimed this 3 days ago. Openbug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
yakew7/Fair-Code#1036 · 2 comments ·
Maintainers usually reply within 1 day
-
documentation help wanted
Difficulty 5/5 Over a week Newbie friendliness 25/100
Maintainers usually reply within 1 day
-
documentation help wanted
Difficulty 5/5 Over a week Newbie friendliness 25/100
Maintainers usually reply within 1 day
All issues in yakew7/Fair-Code
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
area: config effort: S good first issue P3 type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
ferenyl/azuredevopstui#63 ·
-
cursor enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ljofreflor/jobbot#447 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
bug CLI config mcp
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day