The profiler job's make coverage repeats the slow tests the benchmark-harness job runs

Open Beginner friendly
#1,300 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
75/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
github-actions, python
Domain
ci-cd, testing

Research direction

Read .github/workflows/audits.yml and inspect the profiler and benchmark-harness jobs, then check the Makefile targets and slow-test markers they use. Map each slow test file to the job that runs it and confirm no slow test runs in both jobs. Done when the workflow runs every slow test in exactly one required job and a test lists which job runs each slow test file.

Written by the indexing model from the issue text.

Description

ci enhancement testing

Where: .github/workflows/audits.yml (profiler and benchmark-harness jobs).

Current gap: make coverage runs the whole suite including the slow benchmark tests (5 minutes of the 316 s parallel run), and the benchmark-harness job runs tests/test_metrics.py, test_manifest.py, test_strategies.py and test_benchmark.py again.

Suggested approach: Run the slow tests once: either give the benchmark-harness job the slow marker (and collect their coverage there) or have the profiler job use make coverage-fast, keeping every slow test in exactly one required job.

Done when: no slow test runs in both jobs and a test lists which job runs each slow test file.

Dominant language
HTML
Stars
47
Forks
45
Avg merge
2h 50m
Merged PRs (30d)
85

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from yakew7/Fair-Code

All issues in yakew7/Fair-Code

Similar issues

More DevOps issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.