Missing cyclic __proto__ value check

Open
#20 0 comments 0 reactions 1 assignee View on GitHub

@y21 is already working on this.

Since Apr 14, 2023.

Assessment

This issue has not been assessed yet.

Description

A-vm bug
let z = {};
let y = {__proto__:z};
z.__proto__ = y;
y.a

running this crashes dash with a stack overflow because it gets stuck in a recursive "loop" trying to look up property 'a' in its parent __proto__ object if it can't find it

Other JS engines have guards against that. V8 throws Cyclic __proto__ value

Dominant language
Rust
Stars
54
Forks
2
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from y21/dash

All issues in y21/dash

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.