AST pretty-printing is broken for nodes containing interned strings
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript, rust
- Domain
- compilers
Research direction
Start by locating the AST nodes' Display implementations and the StringInterner usage described in the issue. Trace how interned Symbols are currently rendered, then determine how pretty-printing can access their string data. Done means AST output uses surface-looking JavaScript strings and no longer emits interned IDs.
Written by the indexing model from the issue text.
Description
AST nodes can be pretty-printed via their Display impl and should output surface-looking javascript.
At some point string interning was introduced, which means that it now requires access to &StringInterner to be able to get a &str out of a Symbol, which effectively broke these impls (because the impls do not have access and there is no way to pass it as a parameter).
This is currently worked around by simply outputting their ID instead of the string data but this is not very useful.
function <interned id: 248>(<interned id: 249>) {
return <interned id: 249> * <interned id: 249>
}
- Dominant language
- Rust
- Stars
- 54
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from y21/dash
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
-
`parseInt(x, undefined)` and `parseInt(x, null)` should be treated as if they were `parseInt(x, 10)` Open
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
-
A-rt bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
A-vm bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gitbutlerapp/gitbutler#15998 · 1 comment ·
-
bug triage:deciding
Difficulty 1/5 Under an hour Newbie friendliness 88/100
open-telemetry/otel-arrow#4132 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100