Implicit unity option in Enumerate Chord

Open
#951 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
50/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Domain
frontend

Research direction

No files are named in the payload. Start by locating the Enumerate Chord UI and the code that builds its generated ratio list in the scale-workshop frontend; the checkbox and the optional 1/1 prefix belong there. Done when Enumerate Chord offers the option and the generated list starts with 1/1 without breaking existing chord output.

Written by the indexing model from the issue text.

Description

frostburn — 10:27 AM

I couldn't help noticing that you were posting lists of fractions in [scales archive] instead of links to scales. Is there something we could do to make Scale Workshop a more appealing option? How about generating Discord links like this: 21/20 54/49 10/9 7/6 49/40 9/7 35/27 25/18 7/5 72/49 63/40 100/63 5/3 7/4 90/49 50/27 35/18 2/1

beatmaker5710 — 10:36 AM

Hm, I posted directly from my code output, but they would look like that too, if they were from pasted from Scala's Edit current scale window.
In Scale workshop it seems you need to add the ";" sign for ratios to be on one row or to be on separate rows, both of these require more formatting/input.
Can you make Scale workshop accept scales that are typed on one row without ";" , so it is easier to paste from Scala?

frostburn — 10:43 AM

I could expand Enumerate Chord with a checkbox that it automatically prefixes the list with a 1/1. Meanwhile you can copy & paste by adding the implicit 1 manually.

Dominant language
Vue
Stars
123
Forks
23
Avg merge
1d 22h
Merged PRs (30d)
3

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from xenharmonic-devs/scale-workshop

All issues in xenharmonic-devs/scale-workshop

Similar issues

More Web Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.