Marking a file as Viewed should scroll to the next unviewed file
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start by reading the nextUnviewedFile pure function and its unit test to understand the display-order selection. Trace where marking a file Viewed updates the review UI, then ensure the viewport moves to the top of the next unviewed file without wrapping or moving when a file is un-marked; the existing unit test should cover the selection behavior.
Written by the indexing model from the issue text.
Description
Summary
In a large diff, marking a file Viewed leaves the viewport on the collapsed file. The reviewer then scrolls manually to find the next file that still needs review. GitHub's review UI advances to the next unviewed file.
Proposal
When a file is marked Viewed, scroll to the top of the next unviewed file in display order. No scroll occurs when no unviewed file follows (the search does not wrap to earlier files), or when a file is un-marked.
Notes
The selection logic is a pure function (nextUnviewedFile) with a unit test. A PR follows.
- Dominant language
- TypeScript
- Stars
- 206
- Forks
- 37
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from wong2/diffx
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 5/5 Over a week Newbie friendliness 38/100
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
MystenLabs/MemWal#1085 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
📕documentation
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
db-ux-design-system/core-web#8343 ·
Maintainers usually reply within 1 day
-
enhancement triage/needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
heygen-com/hyperframes#4944 ·
Maintainers usually reply within 1 day
-
ai-driven-qa bug claude
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
linagora/twake-calendar-frontend#1493 · 1 comment ·
Maintainers usually reply within 1 day