Refactor: the user interface should be a cancelable promise
@aaroncox is already working on this.
Since Apr 11, 2023.
Assessment
This issue has not been assessed yet.
Description
Right now the only cancelable promise we have is the prompt elements, which means that if the modal is closed, only the prompt elements be canceled.
This kind of illustrates the problem.
- I trigger a signing request
- Instead of completing the request, I close the modal in the web-ui-renderer.
- The promise waiting for it doesn’t cancel, it still is processing, which is why when you see me close the WAX window, all the sudden the error pops up.
The entire web ui renderer would have to be refactored into a cancelable promise to resolve this without a prompt. That’s the right solution I think, but is going to be a significant rewrite to pull off, which I don’t want to have to do at this very moment due to the design work going on.
Internal thread: https://greymass.slack.com/archives/C045MUS6F0F/p1678473763146879
- Dominant language
- Svelte
- Stars
- 6
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.