v6: VersionSupport rejects every 2.x server (major and minor are concatenated)
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Read src/main/java/io/weaviate/client6/v1/internal/VersionSupport.java, especially SemanticVersion.compareTo, and locate the existing tests for VersionSupport. Reproduce the reported results for versions 1.39.13, 2.0.0, 2.5.1, and 10.0.0, then verify that comparison handles major and minor components correctly. Done means 2.x versions are accepted against the 1.32 minimum and the existing 1.x behavior remains correct.
Written by the indexing model from the issue text.
Description
Summary
VersionSupport.SemanticVersion.compareTo builds an integer by concatenating major and minor ("%d%d"), so 1.32 becomes 132 and 2.0 becomes 20. Any 2.x server is therefore judged older than the 1.32 minimum, and the client refuses to connect with WeaviateUnsupportedVersionException.
Reproduction (client 6.3.2)
VersionSupport.isSupported("1.39.13"); // true
VersionSupport.isSupported("1.100.0"); // true
VersionSupport.isSupported("2.0.0"); // false
VersionSupport.isSupported("2.5.1"); // false
VersionSupport.isSupported("10.0.0"); // false
Expected
Compare major first, then minor (e.g. Comparator.comparingInt(SemanticVersion::major).thenComparingInt(SemanticVersion::minor)). This is latent until a 2.0 server ships, but then every deployed client would refuse to connect.
- Dominant language
- Java
- Stars
- 34
- Forks
- 29
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 2
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from weaviate/java-client
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
weaviate/java-client#630 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
weaviate/java-client#629 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
weaviate/java-client#628 ·
-
v6: ShardReplica.shardName has no @SerializedName, so the shard is always nullPossibly taken @dudanogueira claimed this 61 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
weaviate/java-client#621 ·
-
v6: Shard.vectorQueueLenght is misspelled, so the vector queue length is always 0Possibly taken @dudanogueira claimed this 61 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
weaviate/java-client#619 ·
All issues in weaviate/java-client
Similar issues
-
Area-UIUX Issue-Bug Issue-Easy (good first issue)
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
TeamAmaze/AmazeFileManager#4769 ·
Maintainers usually reply within 7 days
-
Expose SManga.memo & SChapter.memo fields in GraphQL APIs to support source-specific client featuresOpenenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Suwayomi/Suwayomi-Server#2551 ·
Maintainers usually reply within 9 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
ShaftHQ/SHAFT_ENGINE#7861 ·
Maintainers usually reply within 1 day