Test that failed Whale multi-input lowering preserves all outputs
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Start with the multi-input lowering flow in src/cli.rs and the existing output-preservation tests in tests/whale_backend.rs. Add CLI coverage for failed second-source lowering, a successful pair, and colliding output plans; run the Whale backend tests. Done when all three cases verify the specified output preservation or failure behavior.
Written by the indexing model from the issue text.
Description
Motivation
src/cli.rs lowers all inputs before publishing output, but tests/whale_backend.rs only exercises previous-output preservation for a single source. The cross-input guarantee has no focused regression.
Scope
Add a CLI test with two Wave inputs and preexisting .wir outputs. Let the first lower successfully and the second fail; verify neither output changes. Also cover a successful pair and colliding output plans. Do not redesign multi-file filesystem transaction semantics.
Difficulty: easy.
Completion criteria
- Assert failed second-source lowering leaves both previous outputs intact.
- Assert a successful pair emits separate verified files.
- Check output-plan collisions fail before replacing files.
- Dominant language
- Rust
- Stars
- 56
- Forks
- 21
- Avg merge
- 4h 58m
- Merged PRs (30d)
- 54
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from wavefnd/Wave
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
good first issue performance
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
Similar issues
-
area:io needs-info needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
bherbruck/solvecraft#3216 · 1 comment ·
-
bug triage/needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
praxis-proxy/grid#412 ·
Maintainers usually reply within 1 day
-
priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
storytold/photocraft#7824 · 1 comment ·
Maintainers usually reply within 1 day
-
area:ui chore could help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day