prevalence-filtering: move Step 2 conditions into Materials and tier them
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- documentation
Research direction
Read the Materials and Step 2 sections of the prevalence-filtering protocol, including the ADR 0017 revision. Move the listed input conditions into Materials and tier them, then leave only computation-time checks in Step 2; verify that every condition and the missing-data rule are represented consistently.
Written by the indexing model from the issue text.
Description
Part of #54. Validates today; this is the ADR 0017 revision.
Untiered in Materials
- L51 "A feature-by-sample abundance table with unique feature and sample identifiers." Reads as must; Step 2 confirms it.
- L53 "Sample metadata identifying the prespecified cohort and any study, batch, body site, or other grouping used to define the analysis set." Reads as must under the default
prevalence_scope.
Only in Step 2, missing from Materials
- L76 "The threshold must be between 0 and 1 inclusive." Range on
prevalence_threshold; Materials gives only the default. must. - L92 "every sample in the selected analysis set has a corresponding abundance column or row." must.
- L97 "Confirm that abundances are numeric, finite, and non-negative." must.
- L98 "Do not silently treat missing values as zero" and the "prespecified missing-data rule" it refers to, which is an input Materials does not list.
- L102 "If a detection floor is used, confirm that all abundance values are on a comparable scale." must, conditional on
detection_rule.
Stays where it is
- L104 zero-total sample handling, and L119
n_sampleszero. Both are computation-time checks, and the first is the standard's own example.
Once Materials carries these, Step 2 restates it and can shrink to the computation-time checks. Three of the five existing must lines are "must be recorded" provenance rules rather than input conditions; fine to keep, but they are not the checks an executor runs before Step 1.
🤖 Drafted with Claude Code
- Dominant language
- No language data
- Stars
- 0
- Forks
- 1
- Avg merge
- 4d 17h
- Merged PRs (30d)
- 6
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from waldronlab/agent-protocols
-
protocol-revision
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
-
humann4 protocols: list the data each step consumes under Materials, then tier its conditionsPossibly taken @lwaldron claimed this 6 days ago. Openprotocol-revision
waldronlab/agent-protocols#59 · 1 assignee ·
-
protocol-revision
Difficulty 3/5 1-2 days Newbie friendliness 64/100
-
jaccard-signature-similarity: tier the Materials conditions and settle the taxonomy-coverage tensionOpenprotocol-revision
Difficulty 3/5 1-2 days Newbie friendliness 53/100
-
Bring existing protocols to ADR 0017: conditions on inputs live in Materials with must or shouldOpenprotocol-revision
Difficulty 4/5 3-5 days Newbie friendliness 45/100
All issues in waldronlab/agent-protocols
Similar issues
-
`max_tokens` is silently ignored on Ollama because `OllamaProvider` sends `max_completion_tokens`Openpydanty:is-working
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
pydantic/pydantic-ai#12066 ·
Maintainers usually reply within 1 day
-
[architect] Stale planning/scratch files at repo root (COMPONENT_SPLIT_SUMMARY.md etc.) describe already-completed workPossibly taken @hivecommons-hive claimed this today. Openagent/architect architecture help wanted stage/040-covered-by-pr tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
kubestellar/console#24716 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
ai_p3 bug comp-datalake
Difficulty 2/5 Half a day Newbie friendliness 70/100
ClickHouse/ClickHouse#128303 · 1 comment ·
Maintainers usually reply within 1 day