Plain `termlens diff` output ends with a blank line, and says "1 rows unchanged"
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
Research direction
Read termlens-cli/src/main.rs around line 409 and diff.rs around lines 312–315, then find the CLI output tests. Verify the plain diff's output bytes end in exactly one newline and that a count of one uses singular wording; add the required CHANGELOG entry. Done when the tests pass and the changelog records the CLI output change.
Written by the indexing model from the issue text.
Description
What happens.
$ termlens diff --color never w1.snap w2.snap | cat -A | tail -2
… 1 rows unchanged$
$
There is an extra empty line after the diff, and the count is "1 rows". The extra line also shows up as a stray blank line before the closing fence in the report action's summary. "no difference" and the coloured output end without it.
Cause. termlens-cli/src/main.rs:409 prints a newline after ScreenDiff's Display, which already ends with writeln! (screen/diff.rs:312-315). The count's wording is at diff.rs:312.
Fix. Drop the extra newline, and use "row" for a count of one.
Done when the plain output ends with exactly one newline, with a test that checks the bytes. Note that this changes the CLI's output; record it in the CHANGELOG.
- Dominant language
- Rust
- Stars
- 28
- Forks
- 24
- Avg merge
- 11h 23m
- Merged PRs (30d)
- 42
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from vyncint/termlens
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 1/5 Under an hour Newbie friendliness 95/100
Maintainers usually reply within 1 day
-
Release notes show a broken link: `extract-changelog.sh` copies a reference but not its definitionOpenbug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
All issues in vyncint/termlens
Similar issues
-
ai_p2 bug comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
ClickHouse/ClickHouse#128306 · 1 comment ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
bug triage
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
area:cli bug priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day