The art editor and mossaic-glyphs always send truecolour on a dark theme
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 83/100
Research direction
Start with the palette fallback in src/primer.rs:338-358, then inspect the color output at src/draw.rs:510, :550, :653 and src/bin/mossaic-glyphs.rs:81. Build the palette with Palette::truecolor_env() and use palette.ansi() in both tools, following the terminal background where known. Done when the glyph checker and chart use matching colors in terminals without COLORTERM and respect known backgrounds.
Written by the indexing model from the issue text.
Description
Today — src/draw.rs:510, :550 and :653 always emit Color::Rgb and assume a dark background. So does src/bin/mossaic-glyphs.rs:81: env -u COLORTERM mossaic-glyphs --color always emits \e[38;2;21;27;35m. The chart falls back to the 256-colour ramp when COLORTERM is unset (src/primer.rs:338-358), for terminals such as macOS Terminal.app. The glyph checker is the diagnostic for exactly those terminals, and it shows different colours from the chart.
Fix — build the palette with Palette::truecolor_env() and use palette.ansi() in both, following the terminal background where it is known.
- Dominant language
- Rust
- Stars
- 2
- Forks
- 1
- Avg merge
- 17h 38m
- Merged PRs (30d)
- 8
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from vyncint/mossaic
-
enhancement good first issue help wanted
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
vyncint/mossaic#57 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 56/100
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 75/100
Maintainers usually reply within 1 day
Similar issues
-
o8 next debug build aborts on Glass to Dark appearance switch (nil identifier messaged before check)Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
hurttlocker/o8#5112 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
memory_patch_page drops the `#` of headings like `## Notes on C#`Possibly taken @viniciusdsandrade claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
akitaonrails/ai-memory#1859 ·
Maintainers usually reply within 1 day
-
bug prio:p3 triaged ux
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day