`vp migrate --full` asks to set up pre-commit hooks even when they're already configured
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- cli, developer-experience
Research direction
Start by reading promptGitHooks() and the existing hasExistingViteHooksPolicy() check used by setupGitHooks(). Trace how vp migrate --full handles existing hooks and look for the relevant prompt tests. Done when existing Vite+ hooks are recognized and the user is no longer asked to set them up as if they were absent.
Written by the indexing model from the issue text.
Description
Description
In a project that already has Vite+ hooks (.vite-hooks/pre-commit, core.hooksPath=.vite-hooks/_), vp migrate --full still asks:
◇ Set up pre-commit hooks to run formatting, linting, and type checking with auto-fixes?
Yes / No
It defaults to Yes and doesn't say hooks already exist. Answering No sounds like it might disable them, though it doesn't.
The agent prompt in the same run detects the existing file and offers Append/Skip:
› Agent instructions already exist at AGENTS.md.
Append
› Skip: Leave existing file unchanged
promptGitHooks() doesn't check hasExistingViteHooksPolicy(), which setupGitHooks() already uses to leave the hook as it is.
Suggested solution
When existing Vite+ hooks are detected, either:
- Skip the prompt and log
Git hooks already configured, or - Say so in the prompt and offer Keep/Skip, like the agent prompt does.
Additional context
vp v1.3.0- Related: voidzero-dev/vite-plus#2459
Validations
- Read the Contributing Guidelines.
- Confirm this request is for Vite+ itself and not for Vite, Vitest, tsdown, Rolldown, or Oxc.
- Check that there isn't already an issue requesting the same feature.
- Dominant language
- Rust
- Stars
- 6.3k
- Forks
- 283
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 200
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from voidzero-dev/vite-plus
-
pending triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
voidzero-dev/vite-plus#2882 · 2 comments ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
voidzero-dev/vite-plus#2097 · 10 comments · 2 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
voidzero-dev/vite-plus#3102 ·
Maintainers usually reply within 1 day
-
`vp run`: Terminal UI for parallel/persistent tasks with per-task log panes (like Turborepo's TUI)Openpending triage
Difficulty 5/5 Over a week Newbie friendliness 35/100
voidzero-dev/vite-plus#3098 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
`vp env exec` / `vp node` ignore `nodeShimMode: system_first`, download a managed runtime (~192 MB) that `vp env clean` then refuses to removePossibly taken @liangmiQwQ claimed this 1 day ago. Openpending triage
voidzero-dev/vite-plus#3093 · 2 comments · 1 assignee ·
Maintainers usually reply within 1 day
All issues in voidzero-dev/vite-plus
Similar issues
-
area:ecosystem documentation
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Chelis-Lang/chelis#3866 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
metasequoiaime/msime#8620 ·
Maintainers usually reply within 1 day
-
agent-detection macos p2 triaged
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
bug documentation sev-0
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day