RFC: Web.HTTP: SSL certification error

Open
  • Is something wrong?
#377 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
vim
Domain
networking, security

Research direction

Start in autoload/vital/latest/Web/HTTP.vim around line 501 and compare how curl and Python handle SSL certificate verification; wget behavior is still unspecified. Review the related vim-gista issue and settle whether an insecure option is needed and which verification behavior it should standardize before defining completion criteria.

Written by the indexing model from the issue text.

Description

クライアントによって SSL certification error が出たり出なかったりします（たぶん）

curl の場合は -k が指定されているので insecure モード https://github.com/vim-jp/vital.vim/blob/master/autoload/vital/__latest__/Web/HTTP.vim#L501
python の場合は特に insecure 指定されていないのでオレオレ証明書だと出る
wget は知らない

これ insecure オプション作成して挙動を統一したほうが良いかと思いますが、どっちに統一するべきだと思いますか？

関連
https://github.com/lambdalisue/vim-gista/issues/58

Dominant language
Vim Script
Stars
586
Forks
64
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from vim-jp/vital.vim

All issues in vim-jp/vital.vim

Similar issues

More Networking issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.