listen: to.any never completes — areAnyComplete passed by value to await, always times out

Bắt đầu trong pkg/zigflow/tasks/task_builder_listen.go, đặc biệt là areAnyComplete, signal/update callback và điều kiện AwaitWithTimeout của await. Tái hiện bằng workflow any.yaml được cung cấp và các Temporal CLI commands, sau đó chạy các bài kiểm thử Go liên quan của dự án hoặc bổ sung coverage cho listen.to.any. Hoàn tất khi signal approve hoặc reject hoàn thành workflow trước timeout, trong khi hành vi của to.all và to.one vẫn được giữ nguyên.

Summary

A listen task using to.any never completes when a matching signal arrives. The workflow waits for the whole timeout and then fails with [408] Timeout Error. to.one with the same signal completes immediately.

Version: zigflow 0.15.2 (source checked at cc35734), Temporal CLI 1.9.1 dev server.

Reproduction

any.yaml:

document:
  dsl: 1.0.0
  taskQueue: repro-listen
  workflowType: listen-any
  version: 0.0.1
  title: listen.to.any repro
do:
  - waitForApproveOrReject:
      metadata:
        timeout: 20s
      listen:
        to:
          any:
            - with:
                id: approve
                type: signal
            - with:
                id: reject
                type: signal
  - done:
      set:
        completed: true

Control one.yaml is identical, except it uses workflowType: listen-one and to.one.with: {id: approve, type: signal}.

WORKFLOW_FILE= WORKFLOW_DIRECTORY=. WORKFLOW_DIRECTORY_GLOB='*.yaml' LOG_LEVEL=debug zigflow run
temporal workflow start  --task-queue repro-listen --type listen-one --workflow-id r-one
temporal workflow start  --task-queue repro-listen --type listen-any --workflow-id r-any
temporal workflow signal --workflow-id r-one --name approve --input '{"ok":true}'
temporal workflow signal --workflow-id r-any --name approve --input '{"ok":true}'

Result

• r-one: COMPLETED {"completed":true} immediately.
• r-any: FAILED after 20s with [408] Timeout Error: no matching event received within 20s.
  • History: TimerStarted (20s) → WorkflowExecutionSignaled (approve) → TimerFired → failed.
  • The debug log shows Waiting for first listening to complete with state=false at start, again right after the signal, and again at timeout.

Cause

In pkg/zigflow/tasks/task_builder_listen.go, areAnyComplete (a bool, line 107) is set to true by the signal/update callback (line 115). But it is passed by value to t.await(...) (line 154), and the AwaitWithTimeout condition inside await (lines 174–190) reads that copy, so it never becomes true.

to.all is not affected because areAllComplete is a slice and shares its backing array.

Suggested fix

Pass *bool (or a func() bool condition) to await instead of the bool value, for example t.await(ctx, workflowCtx, timeout, isAll, &areAnyComplete, areAllComplete) and return *areAnyComplete. This is untested; I don't have a Go toolchain here.