🐛 Bug Report: Langchain instrumentation adds empty create_agent graph nodes for every middleware hook

Đang mở
#4,628 4 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

@DEVJHAWAR11 đang làm issue này rồi.

Từ ngày 16/10/2026.

  • #4629 của @DEVJHAWAR11 — đang mở

Đánh giá

Độ khó
3/5
Thời gian dự kiến
1-2 ngày
Mức phù hợp với người mới
58/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
python
Lĩnh vực
observability

Hướng nghiên cứu

Start with _wrap_middleware_hooks in packages/opentelemetry-instrumentation-langchain/opentelemetry/instrumentation/langchain/__init__.py and compare it with the middleware hook identity check in LangChain’s factory.py. Reproduce the graph change using the script in the issue, then inspect #4000 for the proposed instrumentation-side fix. Done means instrumentation preserves hook identity, adds no empty graph nodes, and does not increase steps toward recursion_limit.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Which component is this bug for?

Langchain Instrumentation

📜 Description
  • _wrap_middleware_hooks wraps the AgentMiddleware base hooks on the class with wrap_function_wrapper (__init__.py#L298-L322). A wrapt FunctionWrapper returns a new bound wrapper on every attribute access, so AgentMiddleware.before_model is AgentMiddleware.before_model becomes False.
  • create_agent uses that identity to decide which middleware overrides a hook (factory.py#L1166-L1185). After instrumenting, every middleware looks like it overrides all four hooks, so the graph gains an empty before_model / after_model node per middleware per model turn. Each node counts as a step against recursion_limit.
  • In our agents with four wrap_model_call middlewares, a model turn went from about 2 steps to about 10, and runs hit GraphRecursionError around 5x earlier than without tracing.
  • Why we're raising this here rather than with LangChain:
    • there might be an improvement to LangChain's check that could harden their logic but I think the tracing is meant to observe the agent without changing how it runs, and #4000 suggests it can be fixed entirely inside the instrumentation.
    • openllmetry's span wrapper also seems to fire only when the base (no-op) hook runs. A middleware that really overrides before_model replaces the base method, so the wrapper never runs and I don't think real hook overrides get an execute_task span today. Could you confirm whether that matches your understanding?
👟 Reproduction steps
  1. Save the script below as repro.py.
  2. Run it in a clean environment:
    uv run --no-project --with "opentelemetry-instrumentation-langchain==0.62.4" --with "langchain>=1.3" --with opentelemetry-sdk python repro.py
    
from importlib.metadata import version
import sys

from langchain.agents import create_agent
from langchain.agents.middleware import AgentMiddleware, wrap_model_call
from langchain_core.language_models.fake_chat_models import FakeMessagesListChatModel
from langchain_core.messages import AIMessage


@wrap_model_call
def passthrough(request, handler):
    return handler(request)


def build_nodes():
    model = FakeMessagesListChatModel(responses=[AIMessage(content="done")])
    agent = create_agent(model, tools=[], middleware=[passthrough])
    return sorted(agent.get_graph().nodes)


print("python", sys.version.split()[0])
for package in ("langchain", "langgraph", "opentelemetry-instrumentation-langchain"):
    print(package, version(package))

print("before instrument:", build_nodes())
print("identity before:", AgentMiddleware.before_model is AgentMiddleware.before_model)

from opentelemetry.instrumentation.langchain import LangchainInstrumentor

LangchainInstrumentor().instrument()

print("after instrument: ", build_nodes())
print("identity after:", AgentMiddleware.before_model is AgentMiddleware.before_model)
👍 Expected behavior

Instrumenting doesn't change the agent graph. A middleware that only implements wrap_model_call adds no nodes:

after instrument:  ['__end__', '__start__', 'model']
identity after: True
👎 Actual Behavior with Screenshots
python 3.14.0
langchain 1.4.6
langgraph 1.2.15
opentelemetry-instrumentation-langchain 0.62.4
before instrument: ['__end__', '__start__', 'model']
identity before: True
after instrument:  ['__end__', '__start__', 'model', 'passthrough.after_agent', 'passthrough.after_model', 'passthrough.before_agent', 'passthrough.before_model']
identity after: False
🤖 Python Version

3.14.0. Also seen on 3.12.

📃 Provide any additional context for the Bug.
  • Versions where we see it: instrumentation 0.62.1, 0.62.3 and 0.62.4, with langchain 1.2.13, 1.3.15 and 1.4.6.
  • #4000 looks like it addresses exactly this. Running the script above against its head commit (43d14f5, with wrapt<2) keeps the graph unchanged and identity True. The branch is based on 0.59.1, so it may need a rebase onto main for the wrapt 2 changes from #4082.
  • In the meantime we're working around it downstream by calling opentelemetry.instrumentation.utils.unwrap on the eight AgentMiddleware hooks right after instrument().
👀 Have you spent some time to check if this bug has been raised before?
  • I checked and didn't find similar issue
Ngôn ngữ chính
Python
Star
7.5k
Fork
1.2k
Merge trung bình
1 ngày 23 giờ
Pull request đã merge (30 ngày)
3

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của traceloop/openllmetry

Tất cả issue của traceloop/openllmetry

Issue tương tự

Thêm issue về Python

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.