chore: install the whole build, run and test toolchain through mise, and consider mise tasks in place of Taskfile

Đang mở
#178 1 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
5/5
Thời gian dự kiến
Hơn một tuần
Mức phù hợp với người mới
12/100
Loại issue
Tái cấu trúc
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
go, python, yaml
Lĩnh vực
build-system, ci-cd, tooling

Hướng nghiên cứu

Start with mise.toml, the go.tool*.mod files, Taskfile.yml and .github/actions/install-task/action.yml to see how tools are installed today. Then read internal/upgrade/taskfile_shape_test.go, which pins the CI jobs to task targets, and scripts/vuln_report.py, which lists the tool roster. Done means the D-04 tool-sourcing decision and the task-runner decision are recorded, with the required job names still intact. This is design work, so check with the maintainer before writing any code.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

area:ci chore priority:low tracking

The build, run and test tools reach a machine in four different ways, and none of them pins the Go toolchain itself. Move the whole tool suite into mise, and consider mise tasks in place of Taskfile.yml.

What exists today (main at 8c0107f1)

  • Go tools are built from five isolated modfiles:

    • go.tool.mod: task, goreleaser, govulncheck
    • go.tool-changie.mod: changie
    • go.tool-golangci.mod: golangci-lint
    • go.tool-lint.mod: actionlint
    • go.tool-proto.mod: buf, protoc-gen-go, protoc-gen-connect-go

    CI builds task through .github/actions/install-task, and the Taskfile runs the rest through go tool -modfile=....

  • Go comes from actions/setup-go with go-version-file: go.mod in CI, and from whatever Go is on the machine locally. Ambient Go 1.27 cannot build cockroachdb/swiss, so every local task test needs GOTOOLCHAIN=go1.26.10, and the Taskfile hard-codes that pin in several places (#104).

  • Node and pnpm: actions/setup-node (Node 24) and web/package.json's packageManager: [email protected].

  • mise already pins hk and @fission-ai/openspec in mise.toml, with mise.lock for linux-x64, linux-arm64 and macos-arm64.

  • Python is the runner's python3. #177 covers it.

  • Tasks: Taskfile.yml holds about 6,200 lines and 73 top-level tasks. CI runs task <target> in every workflow (43 uses in ci.yml).

What to do

  • Pin every tool in mise.toml: Go (from go.mod's go line, which also closes the local half of #104), task or its replacement, goreleaser, govulncheck, changie, golangci-lint, actionlint, buf and the protoc plugins, Node, pnpm, uv, hk and openspec. Keep mise.lock for all three platforms.
  • Use one bootstrap for local and CI. Locally that is mise install. In CI it is either jdx/mise-action or a composite action that keeps D-04 (below).
  • Retire the go.tool*.mod files once mise owns those tools, and point the tool roster that task vuln scans (scripts/vuln_report.py) at the mise-installed binaries.
  • Evaluate mise tasks ([tasks] in mise.toml, or file tasks under .mise/tasks/) as a replacement for Taskfile.yml, as a separate step after the tools move.

Decisions needed

  • D-04, how CI gets tools. .github/actions/install-task/action.yml says every CI build tool is built from the checksummed Go module proxy and never from a GitHub Releases download or an install script, after CDN outages broke arduino/setup-task and taskfile.dev/install.sh in holomush. mise's go: backend keeps that for the Go tools, because it runs go install through the proxy. The aqua: and ubi: backends, and jdx/mise-action itself, download release binaries. Decide per tool, and record the decision.
  • Taskfile vs mise tasks. internal/upgrade/taskfile_shape_test.go makes every ci.yml job a registered task <target> run (inScopeJobs, runBodyExceptions). Moving to mise tasks means rewriting that guard. Several Taskfile targets also carry long, load-bearing comments: the golden suite, the tmux e2e, release rehearsal and fragment checks.
  • Required checks. The protect-main ruleset pins its required checks by job name. The migration must keep every job name.

Suggested order

  1. Pin Go, Node, pnpm and uv in mise, and use them locally.
  2. Move the Go-built tools to mise go: entries, and switch CI bootstrap with D-04 kept or explicitly revised.
  3. Decide on the task runner.

Related: #104 (Go toolchain pin), #177 (uv), #176 (the mutation-check script).

🤖 Generated with Claude Code

https://claude.ai/code/session_016kpFpXsCNuZSmh5X7ebdwU

Ngôn ngữ chính
Go
Star
0
Fork
0
Merge trung bình
7 giờ 42 phút
Pull request đã merge (30 ngày)
111

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của seanb4t/codegraph-go

Tất cả issue của seanb4t/codegraph-go

Issue tương tự

Thêm issue về Go

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.