Hacktoberfest 2026: những issue maintainer đã đánh dấu cho tháng Mười, đang mở và phù hợp người mới. Xem issue Hacktoberfest

New signups don't start in their organizer's language

Đang mở
  • Có gì không ổn?
#627 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
35/100
Loại issue
Tính năng
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
next.js, typescript
Lĩnh vực
backend-api-design, internationalization

Hướng nghiên cứu

Start with the listed signup routes, the New signup form action, MCP create_signup input, and src/lib/magic-compose/persist.ts; read the organizer locale work in #626 first. Trace each create path and its telemetry, then update the tool docs, registry snapshots, privacy page, telemetry docs, and CHANGELOG. Done means tests cover each create path and localeSource, MCP locale handling, and the listed lint, typecheck, knip, test, and database checks pass.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

enhancement pipeline:proposed pipeline:ux

Needs your OK: this makes every new signup take its organizer's language, whether it's made in the browser, by Magic Compose, through the API or by an AI assistant. Nothing changes until Swedish ships. create_signup gains an optional locale. Swap pipeline:proposed for pipeline:ready to have it built.

What happens

Signups have a language (#625) and organizers have one (#626), but nothing connects them: a new signup gets no language.

Fix, in outline

  • The rule. A new signup's language is the one an API or MCP caller sent; otherwise, the organizer's effective language (getOrganizerLocale, #626). The route decides and passes it into the service, so services stay pure.
  • Only once there's a choice. While SHIPPED.participant holds only English, creates store nothing, unless a caller sends a shipped value. That way no signup is pinned to an English nobody chose; these signups follow resolveLocale when read.
  • Every create path:
    • the browser route (src/app/api/signups/route.ts) and the New signup form's action;
    • Magic Compose (src/app/api/signups/magic-compose/route.ts);
    • MCP.
  • MCP create_signup.
    • Add an optional locale to its input with .extend(). Don't put it on FullDraftSchema, which is also Magic Compose's output schema.
    • Strip it before persistDraft, which takes the language as an option and puts it in createSignup's settings (src/lib/magic-compose/persist.ts).
    • Without one, the signup takes ctx.locale from #626.
    • An unsupported value is invalid_input, with a suggestion listing the allowed values.
    • Magic Compose passes the organizer's language through the same option.
  • Telemetry. signup.created gains locale and localeSource (setting | instance | browser | api | default); document both in docs/telemetry.md. The privacy page's activity-log sentence gains them, because browser records a fact taken from the organizer's browser. Its "Last updated" date moves.
  • Docs: the tool description, the registry snapshots, and docs/connect-ai-assistant.md. src/mcp/instructions.ts needn't change, because without a locale the organizer's own language applies.

Watch for

  • Changing the organizer's language later doesn't move existing signups. The language is stored on each signup.
  • Keep groupByFieldRefs as persistDraft builds it today.
  • Add a CHANGELOG entry.

Choices this makes

  • No language picker on the New signup page. Default: none. Most signups are in their organizer's language, and the rest are changed in the signup's Settings tab.

Order

After #626, because the organizer's language and ToolContext.locale come from it.

Done when

  • Tests cover each create path and each localeSource, plus create_signup with a locale, without one, and with an unsupported one.
  • The MCP registry snapshots are updated.
  • pnpm lint && pnpm typecheck && pnpm knip && pnpm test and pnpm test:db pass.

Planned with the owner in https://claude.ai/code/session_01EFKmj716ZY3b3SwR8TV8Y2 and checked against the code on main at 35288fa. The full plan is private to the owner's account: https://claude.ai/artifact/VgQH6U2s2EVx3LX991fJi8 (a Claude session on that account can open it with the Artifact tool's read action). This is part of step 1.1 there.

Ngôn ngữ chính
TypeScript
Star
19
Fork
4
Merge trung bình
21 giờ 3 phút
Pull request đã merge (30 ngày)
176

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của richshaw/OpenSignup

Tất cả issue của richshaw/OpenSignup

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.