Hacktoberfest 2026: những issue maintainer đã đánh dấu cho tháng Mười, đang mở và phù hợp người mới. Xem issue Hacktoberfest

A slot row's hover toolbar covers its "0 of N taken" count

Đang mở
  • Có gì không ổn?
#593 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
4/5
Thời gian dự kiến
1-2 ngày
Mức phù hợp với người mới
52/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
playwright, react, typescript
Lĩnh vực
frontend, testing

Hướng nghiên cứu

Start with src/components/build-wysiwyg/WysiwygSlot.tsx and trace how hover, focus, and the interactive state control the toolbar. Then inspect the existing Playwright setup and tests/e2e/slot-row-layout.spec.ts as a suggested example; verify the count and toolbar do not overlap at 1280 and 390 widths, including a tagged row from #581. Done means the layout check passes, rows at rest stay unchanged, and the listed lint, typecheck, knip, and test commands pass.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

bug pipeline:proposed pipeline:ux

Needs your OK: this moves a slot row's count aside while its Edit, Duplicate and Delete buttons show, so both stay visible. Swap pipeline:proposed for pipeline:ready to have it built.

What happens

On the Build tab, a closed slot row (WysiwygSlot in src/components/build-wysiwyg/WysiwygSlot.tsx) shows its count, such as "0 of 6 taken", at its right edge. Hover the row, or tab into it, and a toolbar with Edit, Duplicate and Delete appears at the same right edge. The toolbar is absolutely placed (right-2 top-1.5) on a white background, so it hides the count. The count is what organizers come to that row for, and it disappears whenever the pointer rests on it.

On a computer this happens on every hover. With the keyboard, it happens on every row that focus passes through.

To see it: at a computer width, create a signup with two slots, and hover either row.

Fix, in outline

  • Move the count aside while the toolbar shows. When the row is hovered or has focus, give the row's button right padding the width of the toolbar, so the count slides left to sit just before it. The summary text gives up the room; it already truncates.
  • Rows at rest don't change, and no row gets taller.
  • Pin it in a browser. Add a Playwright check like tests/e2e/slot-row-layout.spec.ts, which does this for the public page: on hover and on focus, the count's box and the toolbar's box don't overlap, at 1280 and 390 wide. jsdom has no layout, so a unit test can't catch it.

Watch for

  • Phones. There's no hover, but the toolbar shows when the row has focus. Check 390 wide.
  • #581 adds a "Still says TBD" tag to the row and lets its first line wrap on a phone. Check a tagged row too. Whichever lands second has a small merge in WysiwygSlot.tsx.
  • The toolbar's inert switch (the interactive state) must still follow hover and focus.
  • CHANGELOG entry.

Choices this makes

  • Move the count, or always keep room for the toolbar. Default: move the count only while the toolbar shows. Keeping the toolbar's room free on every row would cut every summary short, most of all on a phone, for a toolbar that's hidden most of the time. The cost is that the count slides left on hover.
  • The toolbar stays a hover toolbar, in the same place, with the same buttons. Default: yes.

Done when

  • Hovering or focusing a slot row shows its toolbar and its count side by side, at 1280 and 390 wide, checked by Playwright.
  • A row at rest looks as it does now.
  • pnpm lint && pnpm typecheck && pnpm knip && pnpm test pass, and the new e2e check passes.

Found by the UX walkthrough (scenario O1) on 2026-10-24, and checked against the code on main at 4ed27a9.

Generated by Claude Code

Ngôn ngữ chính
TypeScript
Star
19
Fork
4
Merge trung bình
20 giờ 9 phút
Pull request đã merge (30 ngày)
156

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của richshaw/OpenSignup

Tất cả issue của richshaw/OpenSignup

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.