Hacktoberfest 2026: những issue maintainer đã đánh dấu cho tháng Mười, đang mở và phù hợp người mới. Xem issue Hacktoberfest

Only the Date field's editor says that reminders are on, so an organizer who looks in Settings finds nothing about them

Đang mở
  • Có gì không ổn?
#592 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
3/5
Thời gian dự kiến
1-2 ngày
Mức phù hợp với người mới
58/100
Loại issue
Tính năng
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
react, typescript
Lĩnh vực
frontend

Hướng nghiên cứu

Start with src/app/app/(chrome)/signups/[id]/settings/page.tsx and read src/lib/reminder-fields.ts for sendsReminders and findReminderFields; compare the wording with InlineFieldForm.tsx and the help page’s Reminders section. Add read-only status for on, off, and no date field, using the reminder field’s label, and update the email line when reminders are on. Add tests for each state and the email wording, then run the listed lint, typecheck, knip, and test commands.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

enhancement pipeline:proposed pipeline:ux

Needs your OK: this adds a short line about reminders to the Settings tab. Swap pipeline:proposed for pipeline:ready to have it built.

What happens

Reminders are on for every new signup with a Date field. People who gave an email get one the day before their slot. In the app, an organizer learns this in one place only: on the Build tab, under Fields, by editing the Date field. Its "Send a reminder email before this date" checkbox carries the explanation (InlineFieldForm.tsx). The other hints are small:

  • The Fields list marks the reminder field with a bell. Its words, "Reminders sent the day before this date", are only a tooltip and a screen-reader label (FieldsPopover.tsx).
  • The slot editor mentions reminders only once someone has signed up for that slot (SlotEditor.tsx).
  • The help page "Create and publish your first signup" has a Reminders section.

The Settings tab says nothing about reminders while email is required. Its only line about emails is "We email everyone their link to change or cancel." (src/app/app/(chrome)/signups/[id]/settings/page.tsx). In the walkthrough, an organizer building a volunteer shift grid went to Settings and found no mention of reminders.

The switch is where it is on purpose. #200 put it on the date field and removed the Settings tab's Reminders card, so there is one place to change it (see the CHANGELOG, and the comment in the Settings page). That stays. What's missing is a line where organizers look, saying whether reminders are on and where to change them.

Fix, in outline

  • A "Reminders" line on the Settings tab, in the "Sign-up form" card or a small card of its own. It's read-only, with no second switch. It says one of these, with the reminder field's own label in place of "Date":
    • On: "People who give an email get a reminder the day before their slot's Date. To turn reminders off, open Fields on the Build tab and choose Date."
    • Off: "Reminders are off. To turn them on, open Fields on the Build tab and choose Date."
    • No date field: "No reminders: your slots have no Date field."
  • Work it out on the server with sendsReminders(sig.settings) and findReminderFields (src/lib/reminder-fields.ts), from the signup the page already loads. The tab stays a plain server-rendered page with no script of its own.
  • The email line says it too. With reminders on, "We email everyone their link to change or cancel." becomes "We email everyone their link to change or cancel, and a reminder the day before their slot."

Watch for

  • One switch. Don't add a toggle here unless the owner picks that option below.
  • The same words as the builder. Match the field editor's "Sent the day before" and the help page's REMINDER_WHEN, which reads REMINDER_LEAD_HOURS.
  • Email optional. The Optional line already says people without an email get no reminders. Keep it.
  • Help. Add a sentence to the Reminders section of the help page saying the Settings tab shows whether they're on. Open PRs #574, #576, #578, #580 and #581 also change that page. Whichever lands second has a small merge.
  • The CHANGELOG. The legal pages need no change: nothing new is stored or sent.

Choices this makes

  • On the Settings tab, read-only. It's where the walkthrough's organizer looked, and it keeps #200's one switch on the date field. The alternatives:
    • An on/off switch on Settings for sendReminders, with the date field still choosing which date. More direct, but it brings back the card #200 removed.
    • A line on the Build tab, for example beside the Fields button. Closer to the switch, but the Build tab is already busy.
  • The wording above, in plain words as docs/writing-help.md asks.
  • No link that opens the Fields dialog. The text names the steps instead. A link that opens the dialog on the Date field would need a way into the Build tab's state, like #580's BuildBridge.

Done when

  • The Settings tab shows the right line when reminders are on, when they're off, and when the signup has no date field, with the field's own label. A test pins each.
  • With reminders on and email required, the email line mentions the reminder.
  • pnpm lint && pnpm typecheck && pnpm knip && pnpm test pass.

Found by the UX walkthrough (scenario O2) on 2026-10-24, and checked against the code on main at 4ed27a9.

Generated by Claude Code

Ngôn ngữ chính
TypeScript
Star
19
Fork
4
Merge trung bình
22 giờ 46 phút
Pull request đã merge (30 ngày)
170

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của richshaw/OpenSignup

Tất cả issue của richshaw/OpenSignup

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.