Proposal: deduplicate pending jobs with coalesce

Đang mở
#834 1 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 4 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
5/5
Thời gian dự kiến
Hơn một tuần
Mức phù hợp với người mới
25/100
Loại issue
Tính năng
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
rails, ruby
Lĩnh vực
backend, databases

Hướng nghiên cứu

Read the original uniqueness discussion (#105), concurrency discussions (#176 and #597), and exploratory PR #835 alongside the solid_queue-coalesce reference gem. Start by evaluating whether the proposed pending-job lifecycle and API fit Solid Queue's enqueue, dispatch, and cleanup paths. Done means maintainers agree on whether the feature belongs in core and, if so, define its minimal API and persistence model.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Hi Rosa and team,

David (human) here. We've used Solid Queue in production for nearly a year and love it.

We found that limits_concurrency on_conflict: :discard doesn't deduplicate scheduled jobs. After causing us a production incident, we also discovered that it can discard important work on a retry. I feel that limits_concurrency is not the right tool for deduplication.

Below is my AI-authored issue that describes the problem and my proposed solution, introducing the concept I'm calling coalesce.

I've written a gem solid_queue-coalesce (that composes well with limits_concurrency) exploring these ideas further, including replacing arguments, collecting calls into batches, debouncing and throttling. For now, I'm only proposing basic deduplication, but check out the gem if you're curious about the rest.


Motivation

Issue #105 described one pending job per key, with another allowed as soon as the first starts. limits_concurrency on_conflict: :discard (#176, #594) controls execution, not pending jobs:

  • Scheduled jobs can accumulate, and more than one can run (#597).
  • Calls made during execution can be dropped, even if the running job has already read the state being updated.
  • Callers can't identify which existing job covers their request.

For example, repeated product changes should share one pending reindex. A change during that reindex should schedule the next one.

on_conflict: :discard remains useful for shedding load; coalescing would complement it.

Proposal

class ReindexProductJob < ApplicationJob
  coalesce key: ->(product_id) { product_id }

  def perform(product_id)
    Product.find(product_id).reindex!
  end
end
  • Calls with the same key, including scheduled ones, share one pending job.
  • The key is released when that job starts, so a call during execution queues the next one.
  • Keys are scoped to the job class and batch; retries never coalesce.
  • coalesce_status (:created or :discarded) and provider_job_id tell the caller what happened.
  • Semaphores from limits_concurrency are untouched.

The first job's arguments and scheduled time are retained. Collecting calls, replacing arguments and debouncing are outside this proposal.

Implementation

The standalone gem works but patches private Solid Queue methods, making upgrades fragile. Native support could avoid that. #835 illustrates a minimal implementation using a solid_queue_coalesce_keys table and row locks; it's intended to support discussion, not represent a complete solution. The gem also has benchmarks.

Trade-offs

  • A new table requires a migration.
  • Row locking introduces contention and potential deadlocks; #835 also enqueues coalesced bulk jobs individually, allowing partial batches on failure.
  • Two jobs with the same key can run at once. Add limits_concurrency to prevent that.

Questions

  1. Would you want pending-job coalescing in Solid Queue?
  2. Should it be its own coalesce key: declaration, or an option on limits_concurrency?
  3. If it stays a gem, would you take small public extension points so it doesn't have to patch private methods?

🤖 Written by @dtcristo's agent (Claude Opus 5.5)

Ngôn ngữ chính
Ruby
Star
2.5k
Fork
271
Merge trung bình
5 ngày 6 giờ
Pull request đã merge (30 ngày)
5

Chuẩn bị môi trường

Mở trong Codespaces

Khởi chạy dev container của dự án ngay trên trình duyệt, bằng tài khoản GitHub của bạn.

  • Có Dockerfile hoặc tệp Docker Compose
  • Không có mẫu pull request
  • Không có hướng dẫn đóng góp

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của rails/solid_queue

Tất cả issue của rails/solid_queue

Issue tương tự

Thêm issue về Ruby

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.