[Bug]: TypeScript compiler locations lose line and column in terminal links

Đang mở
  • Có gì không ổn?
#36,183 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

@saphitv đang làm issue này rồi.

Từ ngày 13/11/2026.

  • #36174 của @saphitv — đang mở

Đánh giá

Độ khó
3/5
Thời gian dự kiến
1-2 ngày
Mức phù hợp với người mới
30/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Đình trệ
Công nghệ
typescript
Lĩnh vực
desktop, frontend

Hướng nghiên cứu

The bug is in the terminal link parser and resolver in apps/web, which desktop shares, and the report shows that path(line,col) diagnostics lose their coordinates before shell.openInEditor is called. Start by reproducing with tsc --pretty false output and comparing it with the working path:line:col form. Done means relative and absolute parenthesized locations open at the correct line and column with the link range excluding the trailing colon. Open PR #36174 already targets this, so coordinate with it before writing a competing fix.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Before submitting
  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.
Area

apps/web (also used by desktop's integrated terminal)

Steps to reproduce
  1. From a T3 Code repository checkout with dependencies installed, create a disposable reproduction project:
(
  demo=$(mktemp -d)
  mkdir -p "$demo/src"
  ln -s "$PWD/apps/marketing/node_modules/typescript/bin/tsc" "$demo/tsc"
  {
    printf '\n%.0s' {1..41}
    printf 'const answer: number = "no";\n'
  } > "$demo/src/main.ts"
  printf 'Reproduction project: %s\n' "$demo"
)
  1. Add the printed directory as a project in T3 Code, create a thread, and open its integrated terminal. This makes the terminal link base match the compiler's project root.
  2. In that terminal, run:
./tsc --pretty false --noEmit src/main.ts

The actual compiler output begins:

src/main.ts(42,7): error TS2322: Type 'string' is not assignable to type 'number'.

Hover and Ctrl-click the diagnostic filename (Cmd-click on macOS).

Expected behavior

The editor opens src/main.ts at line 42, column 7. The link range includes the parenthesized location and excludes the trailing colon.

Actual behavior

Only src/main.ts is linked for this relative diagnostic. Clicking opens the file without the location. Capturing the real integrated client's shell.openInEditor request confirms that its target contains the path with no line or column. Absolute parenthesized diagnostic paths also are not understood by the terminal resolver and are treated as literal filenames; that absolute-form failure was verified at the parser/resolver layer.

Impact

Minor bug or occasional failure. Navigation to the diagnostic location is lost, although the relative-path case still opens the correct file.

Version or commit

Verified in the published nightly 0.1.10-nightly.20261113.4630, release commit 7e1a05808aaf5df39fe9d20cc5c3603f3978696a, using the unmodified released Linux x64 server and its bundled web client. Also reproduced on upstream main at 2d8a843e6be9.

Environment

Linux, published nightly server and bundled web client, TypeScript 6.0.3, isolated T3 base directory. The web parser is shared with desktop. No agent turn or source build of T3 Code was used for the nightly verification.

Verified reproduction in the published nightly

Release: v0.1.10-nightly.20261113.4630. The downloaded Linux x64 archive matched the release's SHA256SUMS, and the running server reported serverVersion: 0.1.10-nightly.20261113.4630. No T3 Code source changes or fixture RPC responses were used.

  1. Follow the setup above to create the disposable directory containing src/main.ts and the TypeScript compiler symlink.
  2. Add that directory itself as a project in the installed/nightly T3 Code app. Select the project's current checkout, start a new thread, and open its integrated terminal. Merely changing directories in a terminal belonging to another project is insufficient: links resolve against T3's project root.
  3. Run ./tsc --pretty false. This executes TypeScript 6.0.3 and prints the real src/main.ts(42,7): error TS2322: ... diagnostic.
  4. Hover and Ctrl-click the filename. The underline stops at src/main.ts, and the real editor-opening request omits both coordinates:
{
  "cwd": "/tmp/t3-nightly-terminal-repro/src/main.ts",
  "editor": "vscode",
  "projectRoot": "/tmp/t3-nightly-terminal-repro"
}
  1. Control: run ./tsc --pretty true and Ctrl-click its src/main.ts:42:7 location. The same released client now sends:
{
  "cwd": "/tmp/t3-nightly-terminal-repro/src/main.ts:42:7",
  "editor": "vscode",
  "projectRoot": "/tmp/t3-nightly-terminal-repro"
}

The screenshot below is from the actual published nightly, after running the compiler and hovering the affected link. The two requests above were captured from real clicks, not inferred from the underline. Use Cmd-click instead on macOS.

Open the nightly reproduction screenshot (PNG).

Published nightly links the TypeScript filename but omits the parenthesized location

Supporting evidence

Real integrated-client hover and click evidence is included in the linked fix PR: https://github.com/pingdotgg/t3code/pull/36174.

Workaround

Use --pretty true where practical: its src/main.ts:42:7 format is already supported. This report concerns TypeScript's non-pretty parenthesized diagnostic locations.

Ngôn ngữ chính
TypeScript
Star
24.8k
Fork
6.4k
Merge trung bình
59 phút
Pull request đã merge (30 ngày)
418

Chuẩn bị môi trường

Mở trong Codespaces

Khởi chạy dev container của dự án ngay trên trình duyệt, bằng tài khoản GitHub của bạn.

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của pingdotgg/t3code

Tất cả issue của pingdotgg/t3code

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.