GET and HEAD answer "object not found" when the nodes holding the object cannot be reached

Đang mở
#4,316 3 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Issue này chưa được đánh giá.

Mô tả

bug hal:proposed neofs-storage

Expected Behavior

object not found (2049) means the object does not exist. A node that
could not ask the nodes which may hold the object says that it failed to
find out, with a status clients retry.

Current Behavior

A failed call to a remote node is recorded as ErrObjectNotFound,
whatever the failure was
(get/remote.go#L30-L35),
and the forwarding path returns the same when it reached no node at all
(get/forward.go#L71). So a
node that holds no replica itself and cannot reach those that do answers
code = 2049 message = object not found. The S3 gateway passes it on as
404 NoSuchKey.

0.58.2, four storage nodes, REP 2, 24 objects, 11 of them with no
replica on s01. Traffic between s01 and the other three storage nodes was
dropped; clients still reached s01:

Answers for the 11 objects
object head through s01, before 11 headers
object head through s01, cut off 8 object not found, 3 timeouts of the CLI
object get through s01, cut off 11 object not found
object head through s02, at the same time 11 headers
object head through s01, network back 11 headers
$ neofs-cli object head -r s01:8080 --cid 6XR2jctpN4ZzBP6UhKra26T6WsGDyT6v6kBX68tuQCdF --oid ...
Error: rpc error: read object header via client: status: code = 2049 message = object not found

Possible Solution

Answer "not found" only when every node that may hold the object said so
(or was asked and has no copy). If any of them could not be asked, return
the error of that call.

Steps to Reproduce (for bugs)

  1. Four storage nodes, a container with REP 2, some objects.
  2. Pick an object that node A does not hold: neofs-cli object head --ttl 1 -r A:8080 ... fails for it.
  3. Drop traffic between A and the other storage nodes (iptables in A's network namespace), keeping the client's access to A.
  4. neofs-cli object head -r A:8080 ... for that object.

Context

Found with neofs-bench
(fault scenario, isolate-node). A client that is told "not found"
does not retry and may act on it: an S3 sync tool uploads the object
again, an application treats the key as free.

Regression

Not known.

Your Environment

  • Version used: 0.58.2 (also 0.58.1)
  • Server setup and configuration: 4 storage nodes with 2 shards each, 1 inner ring node, in Docker on one machine; also seen on six cloud servers, one node each
  • Operating System and version (uname -a): Linux 6.8.0 aarch64 (Ubuntu 24.04), Linux 6.12 x86_64 (Debian 13)
Ngôn ngữ chính
Go
Star
37
Fork
56
Merge trung bình
1 ngày 21 giờ
Pull request đã merge (30 ngày)
46

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của nspcc-dev/neofs-node

Tất cả issue của nspcc-dev/neofs-node

Issue tương tự

Thêm issue về Go

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.