Upgrade pydantic to 2.14.1 with a recompiled requirements-dev.txt

Đang mở
#6,373 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
3/5
Thời gian dự kiến
1-2 ngày
Mức phù hợp với người mới
15/100
Loại issue
Tái cấu trúc
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
python
Lĩnh vực
backend

Hướng nghiên cứu

The body says the issue is not open for contribution, so confirm that with maintainers before starting. The work touches requirements.in, requirements.txt and requirements-dev.txt, which must be recompiled with uv pip compile so typing-extensions agrees. Check the QTI models under contentcuration/contentcuration/utils/assessment/qti/ and run the tests in contentcuration/contentcuration/tests/utils/qti/. Done means uv pip sync succeeds and the pinned versions match.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

dependencies DEV: backend python

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Overview

Dependabot PR #6371 bumped pydantic from 2.13.4 to 2.14.1, but its dependency install failed and it was closed unmerged. That PR regenerated only requirements.txt. requirements-dev.txt still pins the old typing-extensions, so the two lock files conflict.

Complexity: Low
Target branch: unstable

Context
  • requirements-dev.in starts with -c requirements.txt, so requirements-dev.txt must match requirements.txt on every package they share. Dependabot regenerates only requirements.txt.
  • These four packages move together in requirements.txt, so they have to be upgraded as a set:
    • pydantic 2.13.4 → 2.14.1
    • pydantic-core 2.46.4 → 2.50.1 (pydantic pins it exactly)
    • typing-extensions 4.15.0 → 4.16.0
    • typing-inspection 0.4.2 → 0.4.4
  • requirements-dev.txt pins typing-extensions==4.15.0 (via exceptiongroup, virtualenv), which conflicts with the 4.16.0 that requirements.txt needs.
  • pydantic is a production dependency. The QTI models in contentcuration/contentcuration/utils/assessment/qti/ are built on it, and publishing converts exercises to QTI with them.
  • The 2.14 release lists two behaviour changes that can affect those models:
    • Enum constructors now run in both validation modes. Enum-typed fields are in constants.py, mathml/fields.py and html/*.py.
    • model_config is no longer mutated. XMLElement in base.py sets extra="forbid", validate_assignment=True and frozen=True.
  • The 2.14 security advisories (GHSA-gj4f-r7mf-jjxh, Fraction exponents; GHSA-955g-x97g-8mcp, multi-host URLs) don't affect Studio. Its pydantic models use no Fraction and no multi-host URL types.
The Change
  • requirements.in should pin pydantic==2.14.1.
  • requirements.txt and requirements-dev.txt should both be recompiled with uv pip compile (the command is in each file's header), so they agree on typing-extensions and every other shared package.
Acceptance Criteria
  • uv pip sync requirements.txt requirements-dev.txt succeeds on Python 3.10.
  • requirements.txt pins pydantic==2.14.1, pydantic-core==2.50.1, typing-extensions==4.16.0 and typing-inspection==0.4.4.
  • requirements-dev.txt pins the same typing-extensions version as requirements.txt.
  • pytest contentcuration/contentcuration/tests/utils/qti/ passes.
  • The full Python CI job runs and passes.
References

AI usage

rtibblesbot (Claude Code) reviewed #6371, recommended closing it, and drafted this issue from that review and the lock files.

Filed from #6371's review.

Ngôn ngữ chính
Python
Star
212
Fork
321
Merge trung bình
1 ngày 7 giờ
Pull request đã merge (30 ngày)
14

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của learningequality/studio

Tất cả issue của learningequality/studio

Issue tương tự

Thêm issue về Python

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.