bug: react-router, page kept for swipe-back stays visible on top when its ionPage outlet is re-entered at a different page in iOS mode

Đang mở
#31,708 1 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
50/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
react, typescript
Lĩnh vực
frontend

Hướng nghiên cứu

Start by reading StackManager.handleOutOfScopeOutlet and the view lookup logic in findViewItems, which the report identifies as the cause. Reproduce the route sequence in the linked example: Step 1 → Step 2 → Home → Settings → Step 1, then compare iOS and md modes. Done means only the page matching the current pathname remains visible when the nested outlet is re-entered.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

package: react type: bug
Prerequisites
Ionic Framework Version

v9.x

Current Behavior

In iOS mode, an ionPage child outlet can end up with two visible pages. The page that
was active when the user left the outlet is never hidden. When the user later returns to
a different page in the same outlet, the old page stays on screen and covers the new one.

The URL is correct, but the user sees the wrong page. No error is thrown. In the DOM,
neither page is hidden:

<ion-router-outlet class="ion-page …">
  <div class="ion-page can-go-back" data-testid="step-1" style="z-index: 101;">…</div>
  <div class="ion-page can-go-back" data-testid="step-2" style="z-index: 101;">…</div>
</ion-router-outlet>

The page that comes later in the DOM is drawn on top. In md mode the same navigation
works.

Expected Behavior

Only the page for the current pathname is visible in the outlet. The page that was
active when the user left the outlet is hidden when another page in that outlet enters.

Steps to Reproduce
  1. Clone the reproduction, check out swipe-preserved-page-visible, then run
    npm install and npm run dev.
  2. Open /onboarding/step1. The green Step 1 page is shown. (Each page has its own
    background color: Step 1 green, Step 2 red, Home blue, Settings purple.)
  3. Press Next. The app pushes /onboarding/step2 (red).
  4. Press Finish. The app pushes /home (blue), outside the onboarding outlet.
  5. Press Settings. The app pushes /settings (purple).
  6. Press Back to Step 1. The app pushes /onboarding/step1.
  7. Observe: the URL is /onboarding/step1, but the red Step 2 page is shown. The status
    bar at the bottom reports
    Visible onboarding pages: step-1, step-2 ← BUG: more than one.

It reproduces on every run (5/5 in Chromium, 3/3 in WebKit). Open
/onboarding/step1?mode=md and repeat the steps to compare: in md mode, the green Step 1
page is shown alone (3/3 runs).

The route shape is:

setupIonicReact({ mode: 'ios' });

<IonRouterOutlet>
  <Route path="/onboarding/*" element={
    <IonRouterOutlet ionPage>
      <Route path="step1" element={<Step1 />} />
      <Route path="step2" element={<Step2 />} />
    </IonRouterOutlet>
  } />
  <Route path="/home" element={<HomePage />} />
  <Route path="/settings" element={<SettingsPage />} />
</IonRouterOutlet>

All navigation uses router.push(path, 'forward').

Code Reproduction URL

https://github.com/ptmkenny/ionic-react-router-6-test/tree/swipe-preserved-page-visible

Ionic Info
Ionic:

   Ionic CLI       : 7.2.1 (/home/node/.npm/_npx/f6fddb685269761d/node_modules/@ionic/cli)
   Ionic Framework : @ionic/react 9.0.10

Capacitor:

   Capacitor CLI      : 8.0.0
   @capacitor/android : not installed
   @capacitor/core    : 8.0.0
   @capacitor/ios     : not installed

Utility:

   cordova-res : not installed globally
   native-run  : 2.0.1

System:

   NodeJS : v26.13.0 (/usr/local/bin/node)
   npm    : 11.20.0
   OS     : Linux 6.18
Additional Information

I used AI (Opus 5.5) to prepare this issue report and reproduction.

Root cause

StackManager.handleOutOfScopeOutlet has a branch for ionPage outlets whose parent
outlet has swipeGesture === true, which iOS mode enables by default. When the outlet
goes out of scope, this branch keeps every child view mounted, so a swipe back can show
them, and returns. It does not hide the active child page: only the parent outlet hides
the ionPage outlet as a whole.

When the outlet comes back in scope at a different child route, nothing hides that page:

  1. Finish pushes /home. The onboarding outlet takes the swipe-preservation branch.
    Step 2 stays mounted and not hidden.
  2. Back to Step 1 pushes /onboarding/step1. findViewItems resolves the entering
    view (Step 1) but no leaving view. It looks the leaving view up by
    routeInfo.lastPathname (/settings) and then routeInfo.prevRouteLastPathname
    (/home). Both belong to the parent outlet, so neither matches a view in this one.
  3. With no leaving view, the transition shows Step 1 and hides nothing. Step 2 has been
    visible since the user left the outlet, so both pages are visible.

The extra Settings step is needed only because of the prevRouteLastPathname
fallback. Going straight from Home back to Step 1 leaves prevRouteLastPathname at
/onboarding/step2, so Step 2 is found as the leaving view and hidden. Any two
navigations outside the outlet before returning trigger the bug.

AI-generated fix

Fix commit: https://github.com/ptmkenny/ionic-framework/commit/3d4f4ace71ada7810c654a1b7136d10f28366d07
(branch: https://github.com/ptmkenny/ionic-framework/tree/swipe-preserved-page-visible)

Ngôn ngữ chính
TypeScript
Star
52.8k
Fork
13.3k
Merge trung bình
3 ngày 1 giờ
Pull request đã merge (30 ngày)
86

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của ionic-team/ionic-framework

Tất cả issue của ionic-team/ionic-framework

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.