In `ask_user` "Other" option has issues: it disappears or gets overridden by later "Other" text
Chưa có ai nhận issue này.
Đánh giá
- Độ khó
- 3/5
- Thời gian dự kiến
- 1-2 ngày
- Mức phù hợp với người mới
- 68/100
Hướng nghiên cứu
Start by reproducing the two cases in the ask_user flow using multiple questions, especially navigating with Shift+Tab and leaving a later Other field uncommitted. Trace how each question stores its selected option and Other text across navigation. Done means committed text remains visible and selected when returning, while uncommitted text stays associated with its own question and does not overwrite another answer.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Mô tả
Describe the bug
Whenever I am filling out ask_user prompts and I use the Other option to do some free text (do that a lot to give additional context) then navigate away and later return to that question, I can't see the Other text anymore. It also seems to default back to the default. Weird thing is that when I submit it still seems to get it. But it just looks like it was lost. Another issue is that if I start typing in a later question but don't submit and go back to a former one, it shows the unsubmitted text as the other. Accidentally hitting enter here will commit the text to the wrong question and override what was in there.
It's done this for a long time and I keep hoping it will just get fixed but it hasn't so I'm posting here about it finally.
Affected version
1.0.85
Steps to reproduce the behavior
Disappearing Text
- Have copilot ask_user with 2+ questions
- Fill out the "Other" section
- Hit enter to go to next question
- Shift + Tab to go back. See that it shows the first option as highlighted, not even "Other" which you selected
- Go down to "Other" and see it is empty. Hit enter anyway
- When question is complete you can see that it submitted the right thing but was bad UX
Overidding Text
- Have copilot ask_user with 2+ questions
- Fill out the "Other" section
- Hit enter to go to next question
- Fill out the "Other" section but don't commit with enter
- Shift + Tab to go back. See that it shows the first option as highlighted, not even "Other" which you selected
- Go down to "Other" and see the text of next question there
- Hitting Enter will override your response with the new text.
Expected behavior
- You enter text into Other
- Whether you commit with enter or not, that text belongs to that section.
- If you don't commit and just hit tab whatever the last selected option was (e.g., the default) remains the selected option, your text is just being held onto just in case
- If you do commit, then the text is saved as your answer and will be the selected option when you navigate back later. For now let's assume you did commit.
- In the next question if you fill out "Other" and don't commit that's fine it's still associated with that question
- Navigate back to previous question
- Since you committed your "other" text, as soon as we land on this previous question it shows the other section highlighted and shows your text not the text of the next question's "other" section. You can edit the text and recommit with the new text. It should never just disappear.
- If instead you had uncommitted text, when you came back to first question, we'd start with the previously committed answer or default and then going down to Other would show your previous text and you can continue to edit it and then commit or still choose not to.
- If you ever want to remove an other option you can always just choose a different option and thus it won't be sent to the agent.
Additional context
No response
- Ngôn ngữ chính
- Shell
- Star
- 11.2k
- Fork
- 1.9k
- Merge trung bình
- 14 giờ 16 phút
- Pull request đã merge (30 ngày)
- 6
Hướng dẫn đóng góp
Bắt đầu từ đâu
- Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
- Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
- Fork repository và làm thay đổi trên một nhánh.
- Mở pull request có tham chiếu số hiệu của issue.
Issue khác của github/copilot-cli
-
triage
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 75/100
github/copilot-cli#4932 ·
-
triage
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 78/100
github/copilot-cli#4909 ·
-
triage
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 76/100
github/copilot-cli#4906 ·
-
triage
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 72/100
github/copilot-cli#4848 ·
-
area:agents area:mcp
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 72/100
github/copilot-cli#4729 ·
Tất cả issue của github/copilot-cli
Issue tương tự
-
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 75/100
elastic/gradle-plugins#156 ·
-
Priority/High ready-for-agent Severity/Major Type/Bug
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 75/100
-
comp/cli P3 type/docs
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 75/100
NousResearch/hermes-agent#119756 · 1 bình luận ·
-
comp: build/pipeline type: bug version: current (v17+)
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 74/100
angular/angularfire#3766 ·
-
out-of-date
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 70/100
CachyOS/CachyOS-PKGBUILDS#1903 ·