Follow-ups of the wrapped component set, from the review of #3172
Maintainer thường phản hồi trong vòng 1 ngày
Chưa có ai nhận issue này.
Đánh giá
- Độ khó
- 5/5
- Thời gian dự kiến
- Hơn một tuần
- Mức phù hợp với người mới
- 20/100
- Loại issue
- Tính năng
- Độ rõ ràng
- Khá rõ ràng
- Mức độ hoạt động
- Sôi nổi
- Công nghệ
- csharp
- Lĩnh vực
- accessibility, frontend
Hướng nghiên cứu
This issue collects follow-ups from reviews of #3172, #3183, #3191, and #3197; it does not name implementation files or tests. Start by choosing one checklist item and reading its linked issue and review context to find the affected entry point. Done means completing that item and checking it off here; the list spans several packages and substantial design work.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Mô tả
The review of #3172 (#3140, A-02) ran the gallery in a browser and left these for later issues. Each is taken by the issue of the admin plan that needs it first, and ticked here when that issue is done.
- Data grid: accessible selection and one tab stop per row, before the first list view of A2. Chromium's tree shows selection cells as
gridcellwith an empty name and no checked or selected state, rows carry noaria-selected, the select-all header is unnamed and not reachable by keyboard, Space does not toggle, and every cell is a tab stop (19 Tab presses across a 4 by 4 grid). Replace the library's select column with a real checkbox per row and in the header, and take data cells out of the tab order. (#3243) - Data grid for list views: external sort with several keys, server paging, loading and empty states, and column order (a column rendered later is appended and not placed, which breaks the per-user column choice). (#3243)
- Inputs for field editors (4.6, 4.17): a number input,
ReadOnly,DirandLangper content locale,OnBlurfor validation on leave,AutoComplete,MaxLengthwith a counter; the time picker drops seconds; a select with a value and no placeholder cannot be cleared; dates and times follow the browser's locale and not the user's culture. (#3245) - Accent color: with an accent set, 12 of the library's 57 brand tokens follow it, so hover and pressed states stay the library's blue; the color on the accent is fixed white, so an accent of
#ffd400gives 1.43:1 on primary buttons. Derive the ramp and guard the contrast. - Icon names for plugin menu items: spec 5.1 names icons by string, and
CmsIcontakes an enumeration of 20. Decide the set and a trim-safe lookup by name (A-18). (#3317) - The library's built-in strings ("Row selected" and the like) come from its own localizer in English. Feed it from the admin's resources.
- Toasts: error toasts dismiss themselves after 7 seconds like the rest (WCAG 2.2.1), and the live region is created together with its content. Route messages through the shell's live regions (#3143).
- Dialog and drawer: no visible close button; a dialog removed from the tree while open cannot return focus; the wrappers re-render the dialog's subtree several times per toggle inside it.
- Compile assets of the library still flow to
FluentCMS.Adminand to plugin halves, with the architecture test of A-06 as the only guard;PrivateAssets="compile"would make misuse a compile error. (#3321)
For A-10 (#3148): the library emits a <style> element for the drawer and inline style attributes on grid cells, so style-src needs 'unsafe-inline'; it uses no eval, no inline script and no inline event attribute.
From the review of #3183 (#3180):
- The gallery's texts in the resources: 100 of the 130 keys of
AdminResources.resxareSystem.Components.*, sample titles and names included, and every contributed translation would have to carry them once a test asks for every key in each shipped culture. Decide whether the gallery's texts are exempt or move to a resource file of their own. - A built-in favicon: without
faviconUrlthe browser asks for/favicon.icoand logs a 404 on every first load, on the error page too, and spec 2.5 promises a built-in one.
From the review of #3191 (#3148, the hosting package):
- Client routes whose last segment has a dot answer 404 on reload (
/admin/media/photo.jpg,/admin/content/1.2), since the fallback toindex.htmltakes only paths that do not look like files. Record the constraint for the routes of the areas, or narrow the fallback to known extensions. - A configured
fluentcms-adminclient is not checked against what the served admin needs: with a secret, or without the scopes, the host starts andconfig.jsonstill lists the five scopes. Refuse it while the admin is on, or document it. - A public seam in place of
InternalsVisibleTofrom Core toFluentCMS.Admin.Hosting, which ties the package to Core's exact version (A-47). - The static files of
/admincount against the pre-authentication rate limit: a cold load is about 230 requests against 6000 per minute per address, so an office behind one address can meet 429 after a deploy. Exempt the static endpoints or documentRateLimit:PreAuth. - Turning the admin off keeps the client row when no other client is configured.
From the second review of #3191 (#3148):
-
A code of its own for a malformed
index.html: the host stops with FCMS1103, titled "FluentCMS not registered", when the admin'sindex.htmlhas no<base href>or two; the code fits a missing manifest or file, not that. -
The component library's icon assemblies in the host's publish root: 22.6 MB of the 25.1 MB of browser assemblies beside
wwwrootare the fourMicrosoft.FluentUI.AspNetCore.Components.Icons.*assemblies, which arrive as NuGet runtime assets and not through the app's output. Keep them out of the host; removing files after publish is not enough, sincedeps.jsonwould still list them. -
Cross-Origin-Opener-Policy: same-originand preview: a preview in aniframeof another origin is unaffected, but one opened withwindow.opento another origin loses its opener both ways (nopostMessage, no handle to reuse or close). If preview needs that, the header becomessame-origin-allow-popups. -
A path base made of dot segments (
/..,/.) passes the start check of the hosting package, whose pattern allows dots; the page's base would then be/../admin/. It is the operator's own setting, so it is a mistake and not an attack, but the check could refuse a segment that is only dots.
From the review of #3197 (#3146, the shell):
- Focus after a navigation from the drawer: under 1024 pixels every sidebar navigation ends on the button that opened the drawer and not on the page's
h1, with nothing announcing that the page changed, because the wrapped dialog raises no callback after a programmatic close, so the layout has no hook. The wrapped set gives the hook, the layout moves focus to the heading, and the end-to-end harness (#3149) asserts it. Before the first list views ship. (#3243) - Theme items as radio items: the component library raises a radio or checkbox menu item's change event again when its state is set back, which made the theme flip; the user menu uses plain items with a check icon and hidden text.
menuitemradiowitharia-checkedis the right pattern once the wrapper can offer it. - A site switch discards an unsaved form without asking: the layout drops the page while the new site loads. Sign-out asks; the switch does not. Save the tracked drafts on a switch (the draft key holds the site), or ask. With the content forms. (#3246)
-
content/{type}/{id}is kept across a site switch when the type exists in the new site, although an entry of a site-scoped type does not; go to the list unless the type is global. The same for a page of a plugin that is disabled in the new site. With the content lists. (#3243) - Grants limited to a locale: the server narrows
/me/accessand/schemaby the request's locale, and the shell asks in the site's default only, so a translator limited tofron anensite sees no types and no notice. The locale switcher re-reads both per locale and resets the locale in the same step as the site (A-17). (#3252) -
IAdminAccess.Allowsis too coarse for two cases: an instance-only endpoint (/users,/members,/jobs,/system) for a caller whose site role lists the permission, where the page always answers 403; and a grant limited to a resource, such as a media folder, which appears only among the limited permissions, so a usable page is hidden. It also offers nothing per content type, which the create and publish buttons of the lists and forms need. -
ContentType.{name}and a plugin menu entry's label key are looked up in the admin package's own resources, so only a satellite assembly ofFluentCMS.Admincan add one. Decide the extension point for a team's app and for a plugin's admin half. -
FocusOnNavigateacts only when the page type changes:content/articletocontent/authorwill be one page type, and focus will not move to the heading. (#3243)
- Ngôn ngữ chính
- C#
- Star
- 567
- Fork
- 107
- Merge trung bình
- 1 giờ 19 phút
- Pull request đã merge (30 ngày)
- 353
Chuẩn bị môi trường
- Có Dockerfile hoặc tệp Docker Compose
- Có mẫu pull request
- Đọc hướng dẫn đóng góp
Bắt đầu từ đâu
- Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
- Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
- Fork repository và làm thay đổi trên một nhánh.
- Mở pull request có tham chiếu số hiệu của issue.
Issue khác của fluentcms/FluentCMS
-
area:localization plugin type:bug
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 78/100
Maintainer thường phản hồi trong vòng 1 ngày
-
area:storage type:bug
Độ khó 4/5 3-5 ngày Mức phù hợp với người mới 48/100
Maintainer thường phản hồi trong vòng 1 ngày
-
area:testing type:bug
Độ khó 3/5 1-2 ngày Mức phù hợp với người mới 72/100
Maintainer thường phản hồi trong vòng 1 ngày
-
area:api area:publishing type:feature
Độ khó 4/5 3-5 ngày Mức phù hợp với người mới 55/100
fluentcms/FluentCMS#3473 · 1 bình luận ·
Maintainer thường phản hồi trong vòng 1 ngày
-
area:storage plugin type:bug
Độ khó 5/5 Hơn một tuần Mức phù hợp với người mới 35/100
Maintainer thường phản hồi trong vòng 1 ngày
Tất cả issue của fluentcms/FluentCMS
Issue tương tự
-
fix(ocr): compile the Tesseract-free pipeline with Tokio runtimeCó thể đã có người làm @Goldziher đã nhận hôm nay. Đang mở
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 78/100
Maintainer thường phản hồi trong vòng 1 ngày
-
priority:P2
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 82/100
-
lompotc silently drops Java/C# class members past 128 instead of erroring, as its header claimsĐang mởbug sev-5 vm
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 76/100
-
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 85/100
-
area:jobads-cv bug FE mvp P3
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 77/100
klasolsson81/jobbliggaren#2271 ·
Maintainer thường phản hồi trong vòng 1 ngày