`CameraComponent.follow` follows the local position of a nested target

Đang mở
#4,238 0 bình luận 0 reaction 1 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

@ufrshubham đang làm issue này rồi.

Từ ngày 19/11/2026.

  • #4239 của @ufrshubham — đang mở

Đánh giá

Issue này chưa được đánh giá.

Mô tả

bug
What happened?

FollowBehavior moves its owner towards target.position (follow_behavior.dart#L55-L58), which is the target's position relative to its parent. When the target is a child of another PositionComponent, that isn't where the target is in the world, so CameraComponent.follow points the camera at the wrong place.

For example, with a knight that is a child of a moving platform and stands at (32, 30) on it, the camera looks at (32, 30) in the world, wherever the platform is. As the platform moves, the camera stays where it is and the knight leaves the screen. follow(target, snap: true) has the same problem, since it sets the viewfinder's position to target.position too (camera_component.dart#L389).

The same happens when a FollowBehavior is used between two components with different parents, e.g. a follower in one container following a target in another.

What do you expect?

The camera follows the target wherever it is in the component tree, as it does for a direct child of the world.

How can we reproduce this?
  1. Add a PositionComponent (the platform) to the world, and move it.
  2. Add the component to follow as a child of the platform.
  3. Call camera.follow(knight). The camera follows the knight's position on the platform, not its position in the world.
What steps should take to fix this?

FollowBehavior will convert the target's position into the coordinate system of the owner's position when the target is a PositionComponent with another parent than the owner: into world coordinates through absolutePosition for an owner that isn't a PositionComponent, such as the camera's Viewfinder, and through absoluteToLocal and positionOf for a PositionComponent owner. When the target and the owner have the same parent, target.position is used as before. CameraComponent.follow will use the same position for snap.

Targets that aren't PositionComponents, such as a PositionProviderImpl, are followed at their position as given, as before. Until the fix is released, a nested target can be followed with camera.follow(PositionProviderImpl(getValue: () => knight.absolutePosition)).

Do have an example of where the bug occurs?
import 'package:flame/components.dart';
import 'package:flame/game.dart';
import 'package:flame/palette.dart';
import 'package:flutter/widgets.dart';

void main() => runApp(GameWidget(game: ReproGame()));

class ReproGame extends FlameGame {
  @override
  Future<void> onLoad() async {
    world.add(RectangleComponent(size: Vector2.all(2000)));
    final platform = MovingPlatform(position: Vector2(100, 100));
    final knight = RectangleComponent(
      position: Vector2(32, 30),
      size: Vector2(16, 28),
      anchor: Anchor.bottomCenter,
      paint: BasicPalette.red.paint(),
    );
    world.add(platform..add(knight));
    camera.follow(knight, snap: true);
  }
}

class MovingPlatform extends RectangleComponent {
  MovingPlatform({super.position})
    : super(size: Vector2(64, 40), anchor: Anchor.center);

  @override
  void update(double dt) {
    position.x += 100 * dt;
  }
}

https://github.com/user-attachments/assets/eb723755-e2dc-4399-aaae-994319cf2c19

Expected: the red knight stays at the center of the screen while the platform carries it. Actual: the camera stays at (32, 30) and the knight moves off the screen.

Relevant log output
Nothing is logged or thrown.
Execute in a terminal and put output into the code block below
[√] Flutter (Channel stable, 3.50.0, on Microsoft Windows [Version 10.0.22631.6199], locale en-US)
    • Flutter version 3.50.0 on channel stable
    • Framework revision ab2912035e (10 days ago), 2026-11-09 08:50:21 -0800
    • Engine revision 371f77202a
    • Dart version 3.14.0
    • DevTools version 2.61.0

[√] Windows Version (11 Pro 64-bit, 23H2, 2009)
[√] Android toolchain - develop for Android devices (Android SDK version 36.1.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2026 18.11.2)
[√] Connected device (3 available)
[√] Network resources

• No issues found!
Affected platforms

All

Other information

No response

Are you interested in working on a PR for this?
  • I want to work on this
Ngôn ngữ chính
Dart
Star
10.8k
Fork
1.1k
Merge trung bình
2 ngày 4 giờ
Pull request đã merge (30 ngày)
61

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của flame-engine/flame

Tất cả issue của flame-engine/flame

Issue tương tự

Thêm issue về Dart

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.