Setting Up DRUF on CKAN 2.11.3 datapusher 3.1.0a
Maintainer thường phản hồi trong vòng 1 ngày
Chưa có ai nhận issue này.
Đánh giá
- Độ khó
- 3/5
- Thời gian dự kiến
- 1-2 ngày
- Mức phù hợp với người mới
- 42/100
Hướng nghiên cứu
Start with plugin.py, where the IFormRedirect try/except silently skips registration on CKAN 2.11.3, and with druf_view.py, whose redirect the report proposes changing to pass druf=1. The template override for package/snippets/resource_form.html is the other place to look. Confirm first whether the maintainers want the workaround in the repo or only a documented fix, since the thread does not settle that. Done means the redirect behaviour is decided and either a warning is logged or the workaround is applied, with the Prefect argparse problem handled separately.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Mô tả
Setting Up DRUF on CKAN 2.11.3 — Issues & Workarounds
Notes from setting up the DRUF (Dataset Resource Upload First) workflow with DataPusher+ on a CKAN 2.11.3 instance.
Posted here so other developers hit the same wall less hard.
Environment
| Component | Version |
|---|---|
| CKAN | 2.11.3 (stable release) |
| DataPusher+ | latest (main / 0e46e10) |
| Python | 3.10 |
| Prefect | 3.x (as required by DP+) |
| ckanext-scheming | latest |
Issue 1: Prefect Worker Fails to Start — BooleanOptionalAction ImportError
What happened
After installing DataPusher+ and its requirements, attempting to start the Prefect worker immediately crashed with:
ImportError: cannot import name 'BooleanOptionalAction' from 'argparse'
Full traceback:
Traceback (most recent call last):
File ".../pydantic_settings/env_settings.py", line ..., in ...
from argparse import BooleanOptionalAction
ImportError: cannot import name 'BooleanOptionalAction' from 'argparse'
(/path/to/venv/lib/python3.10/site-packages/argparse.py)
Why it happens
pydantic-settings (a Prefect dependency) imports BooleanOptionalAction, which was added to the Python standard library in Python 3.9. On Python 3.10 this should be available without issue.
The problem is that some older pip packages distribute a standalone argparse module and install argparse.py directly into site-packages. Because site-packages is earlier in Python's module search path than the standard library, this legacy file shadows the stdlib argparse, causing the import to fail even on Python 3.10.
You can confirm this is your issue:
python3 -c "import argparse; print(argparse.__file__)"
# If it prints a site-packages path instead of a stdlib path, you have the problem.
# Normal (correct) output looks like: /usr/lib/python3.10/argparse.py
# Problem output looks like: /path/to/venv/lib/python3.10/site-packages/argparse.py
Fix
Remove (or rename) the shadowing argparse.py from site-packages:
# Find it
find /path/to/your/venv -name "argparse.py" -path "*/site-packages/*"
# Remove it (or rename to .bak if you want to be cautious)
rm /path/to/your/venv/lib/python3.10/site-packages/argparse.py
After removing, verify the stdlib version is now loaded:
python3 -c "import argparse; print(argparse.__file__)"
# Should now print something like: /usr/lib/python3.10/argparse.py
python3 -c "from argparse import BooleanOptionalAction; print('OK')"
# Should print: OK
Preventive fix for Docker / CI builds
If you are building in Docker, add a cleanup step after all pip install commands to remove any stray argparse.py that may have been deposited by a transitive dependency:
# Defensive cleanup: remove any legacy argparse.py that shadows the stdlib.
# pydantic-settings (Prefect dep) needs BooleanOptionalAction (stdlib 3.9+).
RUN find /usr/local/lib /usr/lib -name "argparse.py" -path "*/site-packages/*" -delete || true
The || true prevents the build from failing if no such file exists, which is the normal case.
Issue 2: DRUF Does Not Redirect to Metadata Form After Resource Upload
What happened
After getting the Prefect worker running and enabling DRUF in ckan.ini:
ckanext.datapusher_plus.enable_druf = true
ckanext.datapusher_plus.enable_form_redirect = true
The workflow partially works — clicking "Add Dataset" correctly skips the metadata form and goes straight to the resource upload page. But after uploading the file and clicking "Add", the user lands on the dataset read page (/dataset/{name}) instead of the metadata edit form (/dataset/{id}/edit).
CKAN request log:
302 POST /dataset/{id}/resource/new
302 GET /dataset/{id}
200 GET /dataset/{dataset-name}
Expected:
302 POST /dataset/{id}/resource/new
302 GET /dataset/{id}/edit
200 GET /dataset/{id}/edit
The dataset ends up published with only the auto-generated placeholder name (e.g. dataset97689) and no real metadata filled in.
Root cause: IFormRedirect does not exist in CKAN 2.11.3
DataPusher+ implements CKAN's IFormRedirect plugin interface to intercept the post-save redirect and point it at the metadata edit form. In plugin.py:
try:
p.implements(p.IFormRedirect)
except (ImportError, AttributeError):
# IFormRedirect not available in this CKAN version
pass
The resource_save_redirect method (the one that would return the dataset.edit URL) is only ever called if IFormRedirect is registered — which requires the interface to exist in the CKAN version being used.
IFormRedirect does not exist in any stable CKAN release as of 2.11.3. It was introduced on the unreleased branch 7778-iformredirect. The DataPusher+ README links to this branch under the "Enabling DRUF" section:
"To enable DRUF you need DRUF compatible ckan version" →
https://github.com/ckan/ckan/tree/7778-iformredirect
Because the try/except silently swallows the AttributeError, CKAN starts without error and no warning is logged. The redirect hook simply never fires. CKAN's default post-resource-save redirect logic takes over — which sends the user to the read page.
How CKAN's redirect logic works (relevant context)
In ckan/views/resource.py, after a resource is saved, the redirect destination is determined by the value of a save hidden field posted with the form:
save field value |
What CKAN does |
|---|---|
go-metadata |
Activates the package (state=active), redirects to dataset read page |
go-dataset |
Redirects to dataset edit page (the metadata form) |
go-dataset-complete |
Redirects to dataset read page |
again |
Redirects to resource new page (add another resource) |
CKAN's standard "Add" button in package/snippets/resource_form.html uses value="go-dataset-complete" — which goes to the read page. That is what fires when DRUF's IFormRedirect hook does not exist to intercept it.
Additionally, the DRUF-created package has state='active' (set in druf_view.py). Because the package is not in draft state, CKAN renders the new_resource_not_draft.html template rather than the wizard-stage version — so there is no "Finish" button, only "Add" (go-dataset-complete).
Workaround for CKAN 2.11.3
Since IFormRedirect is unavailable, the workaround is to:
- Have
druf_view.pypass a?druf=1query parameter on its redirect to the resource upload page. - Override
package/snippets/resource_form.htmlin your CKAN extension to detect?druf=1and swap the "Add" button (go-dataset-complete) for a "Save & Fill Metadata" button (go-dataset) — which CKAN already routes todataset.edit.
Step 1 — druf_view.py patch:
# In ckanext/datapusher_plus/druf_view.py, change line 46 from:
return h.redirect_to('dataset_resource.new', id=pkg['id'])
# to:
return h.redirect_to('dataset_resource.new', id=pkg['id'], druf='1')
In Flask/CKAN, url_for kwargs that are not part of the URL rule are appended as query string parameters. This produces /dataset/{id}/resource/new?druf=1.
Step 2 — Template override (in your CKAN extension):
Create templates/package/snippets/resource_form.html inside your CKAN extension:
{% ckan_extends %}
{% block add_button %}
{% if request.args.get('druf') %}
<button class="btn btn-primary" name="save" value="go-dataset" type="submit">{{ _('Save & Fill Metadata') }}</button>
{% else %}
{{ super() }}
{% endif %}
{% endblock %}
{% ckan_extends %} resolves to CKAN's own resource_form.html snippet. request.args is the Flask query string dict and is available in all CKAN Jinja2 templates.
How the full flow works after the workaround:
- User clicks "Add Dataset" → DRUF view (
POST /resource-first/new) creates placeholder package druf_view.pyredirects toGET /dataset/{id}/resource/new?druf=1- CKAN renders
new_resource_not_draft.html→ loadsresource_form_snippet - Your extension's
resource_form.htmloverride is served;request.args.get('druf')is'1' - "Save & Fill Metadata" button (
value="go-dataset") rendered instead of "Add" - User uploads file and clicks "Save & Fill Metadata"
- Form POSTs to
/dataset/{id}/resource/newwithsave=go-dataset - CKAN saves the resource, hits
elif save_action == 'go-dataset':→ redirects toGET /dataset/{id}/edit - User lands on the metadata edit form
Note: ?druf=1 does not need to be in the form's action URL. The save field value in the POST body is what drives the redirect, not the URL. The query parameter is only needed during the GET (template render) to know which button to show.
Proper fix (awaiting CKAN merge)
The proper solution is for IFormRedirect to be merged into a stable CKAN release. Track the PR here: https://github.com/ckan/ckan/tree/7778-iformredirect. Once that branch lands in a stable CKAN release, the try/except in plugin.py will succeed, resource_save_redirect will be called, and the workaround above will no longer be needed (though it is harmless to leave in place — on CKAN versions that do have IFormRedirect, the ?druf=1 query parameter will still be present and request.args.get('druf') will still return '1', but the redirect will already have been handled correctly by IFormRedirect before the template is even rendered for a second time).
Summary
| # | Issue | Root Cause | Workaround |
|---|---|---|---|
| 1 | Prefect worker crashes — BooleanOptionalAction ImportError |
Legacy argparse.py in site-packages shadows stdlib |
Remove site-packages/argparse.py; add defensive find ... -delete to Docker build |
| 2 | DRUF sends user to read page instead of metadata form | IFormRedirect not in CKAN 2.11.3 (only on unreleased branch 7778-iformredirect) |
Pass ?druf=1 in druf_view.py redirect; override resource_form.html to swap button to go-dataset |
Both workarounds are non-destructive and compatible with future CKAN versions that do implement IFormRedirect.
- Ngôn ngữ chính
- Python
- Star
- 47
- Fork
- 33
- Merge trung bình
- 2 giờ 28 phút
- Pull request đã merge (30 ngày)
- 10
Chuẩn bị môi trường
Dự án này không cung cấp dev container, Dockerfile hay hướng dẫn đóng góp, nên bạn cần tự thiết lập môi trường: hãy bắt đầu từ README và xem hướng dẫn đóng góp lần đầu của chúng tôi để biết các bước chung.
Bắt đầu từ đâu
- Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
- Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
- Fork repository và làm thay đổi trên một nhánh.
- Mở pull request có tham chiếu số hiệu của issue.
Issue khác của dathere/datapusher-plus
-
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 65/100
dathere/datapusher-plus#359 ·
Maintainer thường phản hồi trong vòng 1 ngày
-
"Total elapsed time" in the JOB DONE line is ~1.79 billion seconds (perf_counter overwrites the time.time() start)Có thể đã có người làm @tino097 đã nhận 14 ngày trước. Đang mở
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 35/100
dathere/datapusher-plus#355 ·
Maintainer thường phản hồi trong vòng 1 ngày
-
FormulaProcessing stage always skipped on CKAN 2.10+: ckan.plugins is a list, stage calls .split() on itCó thể đã có người làm @tino097 đã nhận 14 ngày trước. Đang mở
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 25/100
dathere/datapusher-plus#354 ·
Maintainer thường phản hồi trong vòng 1 ngày
-
Độ khó 4/5 3-5 ngày Mức phù hợp với người mới 48/100
dathere/datapusher-plus#340 ·
Maintainer thường phản hồi trong vòng 1 ngày
-
Prefect requires Sqlalchemy2Đang mở
Độ khó 3/5 1-2 ngày Mức phù hợp với người mới 53/100
dathere/datapusher-plus#338 ·
Maintainer thường phản hồi trong vòng 1 ngày
Tất cả issue của dathere/datapusher-plus
Issue tương tự
-
documentation good first issue priority: P2 status: ready
Độ khó 1/5 Dưới một giờ Mức phù hợp với người mới 88/100
RhinoLink-Tech/data-fabric#500 ·
Maintainer thường phản hồi trong vòng 1 ngày
-
backlog
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 78/100
EchoTools/nevr-runtime#2384 ·
Maintainer thường phản hồi trong vòng 1 ngày
-
[Bug]: The H2 series' and the H3C's fan 3 is labelled "Chamber Fan", Bambu calls it the exhaust fanĐang mởarea:ui
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 88/100
Maintainer thường phản hồi trong vòng 1 ngày
-
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 68/100
btclib-org/btclib#3062 ·
Maintainer thường phản hồi trong vòng 1 ngày
-
Run evals automatically in CIĐang mởarea:evals area:infra enhancement
Độ khó 2/5 1-3 giờ Mức phù hợp với người mới 74/100
jse-avl/support-bot#4 · 1 bình luận ·