Bug: TablesDB listRows total:false uses a GET encoding that does not suppress totals in measured Cloud requests

Đang mở
#168 3 bình luận 0 reaction 0 người được giao Xem trên GitHub

Chưa có ai nhận issue này.

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
48/100
Loại issue
Lỗi
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
nodejs, typescript
Lĩnh vực
api, backend-api-design

Hướng nghiên cứu

Start with the pinned src/client.ts source and the corresponding SDK Generator platform templates, then verify GET boolean parsing against a nonempty list; the report notes that an empty-table fixture is insufficient. Confirm the intended server contract before choosing whether the serializer, server parser, or both should change. Done means regression coverage for true, false, omission, query arrays, and POST-body behavior, while preserving JSON booleans and booleans inside serialized Query JSON.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Reproduction steps

With an isolated, frozen install of [email protected], run the following .mjs file with Node 26. It sends one HTTP GET to a local server and requires no Appwrite credentials or Cloud writes.

import { Client, TablesDB } from "node-appwrite";
import assert from "node:assert/strict";
import { createServer } from "node:http";

let observed;
const server = createServer((request, response) => {
  observed = new URL(request.url, "http://fixture.invalid").searchParams.get("total");
  response.writeHead(200, { "content-type": "application/json" });
  response.end('{"total":0,"rows":[]}');
});
await new Promise(resolve => server.listen(0, "127.0.0.1", resolve));
try {
  const client = new Client().setEndpoint(
    `http://127.0.0.1:${server.address().port}/v1`,
  ).setProject("fixture-project");
  await new TablesDB(client).listRows({
    databaseId: "db",
    tableId: "cost",
    total: false,
  });
  console.log({ observed }); // { observed: 'false' }
  assert.equal(observed, "false"); // Characterization, not the desired fix.
} finally {
  server.closeAllConnections();
  await new Promise(resolve => server.close(resolve));
}
Expected behavior

Passing total: false should suppress total counting on a nonempty list. The SDK and the server should agree on the GET boolean representation. In the measured Cloud boundary below, total=0 produced the intended response while total=false did not. Please confirm the intended server contract before deciding whether to fix the serializer, server parser, or both.

Actual behavior

The published SDK emits the string false in the GET URL. A separate, read-only Appwrite Cloud SGP probe queried an existing nonempty table with identical limit/order queries:

GET flag Response total Rows returned
total=false 8 1
total=0 0 1
total=true 8 1
total=1 8 1

The returned row hash matched between the false/zero variants. The behavior held with and without X-Appwrite-Response-Format: 2.3.0. No row was inserted or changed. An empty-table fixture alone cannot establish that counting was suppressed. This is a response/counting observation, not a measured billing or query-performance claim.

Environment and source pin
  • Published dependency: [email protected], exact frozen lock.
  • SDK tag 29.0.0 resolves to commit f333acaff4fcc23956b6086a537c51c87123f40d: client source.
  • Fresh local replay: Windows, Node 26.10.0, pnpm 12.9.0. The real-SDK compatibility suite passed two tests, including raw string-false characterization and an explicit GET-total-only zero/one shim. The same pinned suite also passed Linux CI.
  • Cloud measurement: SGP, captured October 2026. The Cloud engine version was not independently identified; 2.3.0 above is the requested response-format header, not a claim about the deployed engine.
  • No claim that other SDK/server versions behave identically. Project IDs, credentials, private receipts and row content are excluded.
Suggested investigation and regression coverage

Please verify GET boolean parsing against a nonempty list and the corresponding SDK Generator platform templates. If zero/one serialization is required, preserve JSON request-body booleans and booleans inside serialized Query JSON. Cover true, false, omission, query arrays and POST-body behavior; make the desired-fix regression fail against the previous implementation first.

Our prototype uses an explicit local shim for the GET total flag. We have not patched the vendor package or migrated production Functions to the Node SDK. A general upstream change should be reviewed at the generator/server contract boundary rather than copying that narrow workaround.

Duplicate check

Searched open and closed sdk-for-node issues/PRs for total and false, and sdk-generator issues/PRs for total with false; no matching report was found at posting time. Only this report is being opened; no parallel issue is being filed in the generator repository.

Ngôn ngữ chính
TypeScript
Star
256
Fork
45
Merge trung bình
8 giờ 59 phút
Pull request đã merge (30 ngày)
4

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của appwrite/sdk-for-node

Tất cả issue của appwrite/sdk-for-node

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.