feat(aidd-dev): audit codebase compliance against project rules

Đang mở
#864 2 bình luận 0 reaction 0 người được giao Xem trên GitHub

Chưa có ai nhận issue này.

Đánh giá

Độ khó
5/5
Thời gian dự kiến
Hơn một tuần
Mức phù hợp với người mới
45/100
Loại issue
Tính năng
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
markdown
Lĩnh vực
devtools, tooling

Hướng nghiên cứu

Start with plugins/aidd-dev/skills/04-audit/SKILL.md and its existing actions, then read 05-review/SKILL.md and actions/03-review-relevancy.md to trace Rule discovery and report conventions. Define the optional audit flow within the existing report and findings table, covering repository-wide code and the four required outcomes. Done means the acceptance criteria hold without adding a skill or pillar or changing 05-review.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Problem

aidd-dev:05-review discovers declared project Rules at runtime and checks conformance, but only for a diff. aidd-dev:04-audit assesses the existing codebase read-only, but its current quality pillars do not explicitly cover compliance with project Rules.

There is therefore no explicit repository-wide workflow that answers: does the existing codebase comply with all applicable project Rules? This leaves legacy code, Rules introduced after code was written, code created outside AIDD, and code never included in a reviewed diff without that assessment.

Scope
  • Implement this as an optional rule-conformance action within aidd-dev:04-audit, reusing the existing audit report and findings table.
  • Discover applicable project Rules at runtime and determine their scope before applying them, using the existing Rule-discovery approach from 05-review.
  • Evaluate existing repository code, not only a diff, against those Rules.
  • Produce one outcome for each applicable Rule: compliant, confirmed violation with the Rule plus affected file:line and supporting evidence, interpretation-dependent, or not verifiable from repository evidence.
  • Produce a global clean result only when all applicable Rules that are verifiable from repository evidence are compliant.
  • Keep this within aidd-dev: it must not depend on aidd-context or call a skill from another plugin. aidd-dev evaluates code conformance; aidd-context owns Rule content and context health (placement, scope, duplication, conflicts, and loading). Both inspect project artifacts directly, and neither plugin calls the other.
  • Do not introduce a new skill or audit pillar, and do not change the existing diff-only contract of 05-review.
Acceptance criteria
  • The optional 04-audit action discovers declared project Rules at runtime and determines applicability before evaluating code, reusing the approach used by 05-review.
  • It evaluates existing repository code, including code outside the current diff.
  • It reuses the existing audit report and findings table.
  • It produces exactly one outcome for each applicable Rule, using one of: compliant, confirmed violation, interpretation-dependent, or not verifiable from repository evidence.
  • Each confirmed violation identifies the Rule, affected file:line, and repository evidence.
  • Interpretation-dependent findings are distinct from confirmed violations.
  • A Rule that cannot reasonably be verified from repository evidence is reported as not verifiable from repository evidence, not asserted as a violation.
  • A global clean result is possible only when every applicable, verifiable Rule is compliant.
  • The default workflow is read-only and does not modify Rules or application code.
  • The implementation adds neither a new skill nor a new audit pillar, creates no aidd-dev to aidd-context dependency or cross-plugin call, and does not change the existing diff-only 05-review contract.
Prior art in this repo
  • 04-audit/SKILL.md#L3-L33 is the read-only codebase audit, but its seven listed pillars do not explicitly include compliance with project Rules.
  • 05-review/SKILL.md#L3-L27 defines a read-only review of a diff; review-relevancy is its Rule-conformance axis.
  • 03-review-relevancy.md#L3-L24 discovers declared Rules at runtime, evaluates a diff, cites violated Rules, and writes None. when clean.
  • docs/ARCHITECTURE.md#L85-L109 assigns code transformation to aidd-dev and places a missing capability with the plugin whose concern owns it; this makes aidd-dev the appropriate scope without requiring a new skill or audit pillar.
  • #791 is candidate Rule to existing Rules during Rule generation; #792 is Rules to Rules; #793 is context artifacts to ownership and placement; #796 is Rule to development decision to artifact. None evaluates existing Rules against the existing codebase.

I checked the current main contracts and searched open and closed issues and pull requests for codebase Rule compliance, Rule conformance, and equivalent wording. No duplicate was found.

Out of scope
  • Automatically fixing violations or modifying Rules or application code.
  • Auditing Rule quality, conflicts, duplication, or drift; that is #792.
  • Auditing context-artifact ownership or placement; that is #793.
  • Tracing a Rule's influence on development decisions; that is #796.
  • Defining universal Rule precedence across AI hosts.
  • Treating every Rule as statically verifiable.
Ngôn ngữ chính
TypeScript
Star
481
Fork
45
Merge trung bình
17 giờ 40 phút
Pull request đã merge (30 ngày)
106

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của ai-driven-dev/framework

Tất cả issue của ai-driven-dev/framework

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.