React Query Devtools retains detached transition targets through bundled Kobalte registry

Đang mở
#12,581 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
25/100
Loại issue
Lỗi
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
javascript, react
Lĩnh vực
frontend, performance

Hướng nghiên cứu

The retention is in the published Devtools bundle, where transitionsByElement and the bundled Kobalte utils 0.9.2 track transition targets on the body. Start from the linked repro's /react/ entry and window.repro.countAliveTargets() after a forced GC, then compare against the standalone Kobalte example. Done means the stopped-event run drops to 0 after GC without breaking active transitions on connected elements, which depends on the upstream Kobalte fix being released into Devtools.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Describe the bug

React Query Devtools 5.107.1 embeds Kobalte's global transition tracking. If an application element stops a native transitionend event from bubbling and is removed after the transition completes, the bundled registry can retain the detached element. The body-level registry tracks application elements outside the Devtools UI too.

In a minimal React app with one stable query and the Devtools panel mounted, 1,000 completed and removed transition targets remain alive after manual Chrome garbage collection. In the normal-event control, 0 remain alive after GC.

The underlying Kobalte issue and proposed fix are:

This report tracks the downstream Devtools impact and eventual inclusion of the upstream fix. The tested published @tanstack/query-devtools bundle includes transitionsByElement and the affected utils 0.9.2 code. Updating an application's separate Kobalte dependency will not replace code already embedded in that bundle.

Your minimal, reproducible example

https://github.com/whatisyourname0/kobalte-transition-retention-repro/tree/e26a70a/react

The repository includes both a standalone Kobalte example at / and the React Query Devtools example at /react/. The React entry does not execute a direct Kobalte import or use a patched dependency. It mounts QueryClientProvider, one stable sample query, and ReactQueryDevtools with initialIsOpen: true.

Steps to reproduce
git clone https://github.com/whatisyourname0/kobalte-transition-retention-repro.git
cd kobalte-transition-retention-repro
git checkout e26a70a
npm ci
npm run dev
  1. Open /react/ on the displayed local origin. Wait until the Devtools panel and Sample query ready appear.
  2. Click Run stopped events. Wait for completion: 1,000 started, 1,000 ended, 1,000 removed, 0 cancelled. These are real CSS transitions; each target stops transitionend propagation, then is removed after completion.
  3. Open Chrome DevTools → Memory → Collect garbage.
  4. Evaluate window.repro.countAliveTargets() in Console: 1000.
  5. Reload, wait for the panel, click Run control, wait for completion, and collect garbage again. The same expression returns 0.
  6. To inspect ownership, take a heap snapshot after the stopped case and inspect detached retention-probe targets and transitionsByElement in the Devtools bundle.

The fixture keeps only WeakRefs once the async run settles and never logs/exports individual targets. A count before GC is not evidence of retention. callbackRan: null on the React page is intentional: it does not import Kobalte's private callback helper. The standalone page separately demonstrates the blocked callback and Map retaining path.

Expected behavior

Removed application elements are released even when completion events do not reach the body-level listener. Active transitions on connected elements continue to be respected.

How often does this bug happen?

Reproduced in the stopped-event run; the normal-event control released all targets.

Screenshots or Videos

Reproduction UI (not a Memory-panel capture):

React Query Devtools reproduction

Platform

macOS 26.7; Chrome 157.0.8103.78.

Tanstack Query adapter

react-query

TanStack Query version

@tanstack/react-query and @tanstack/react-query-devtools: 5.107.1. React / React DOM: 19.3.1. Exact dependencies are locked. Node >=24 to run the fixture.

TypeScript version

Not applicable; the reproduction uses JavaScript.

Additional context

Both React-page cases completed all 1,000 native transitions and removed all targets with no cancellation events. The affected transition has already ended before removal, so removal cannot be expected to emit transitioncancel for it.

The Kobalte-only reproduction has also been compared against the proposed upstream fix (1,000 retained → 0 after GC). The React Devtools reproduction uses the unmodified published Devtools bundle; that candidate comparison has not been repeated against a rebuilt Devtools bundle. This report concerns the demonstrated DOM retention condition, not a claim that Query cache retention or all application memory growth has this cause.

Could you track incorporating the Kobalte fix into a Devtools release once upstream review/release is complete, or advise on a suitable interim mitigation?

Ngôn ngữ chính
TypeScript
Star
50.6k
Fork
4.2k
Merge trung bình
8 giờ 37 phút
Pull request đã merge (30 ngày)
450

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của TanStack/query

Tất cả issue của TanStack/query

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.