Hacktoberfest 2026: những issue maintainer đã đánh dấu cho tháng Mười, đang mở và phù hợp người mới. Xem issue Hacktoberfest

SQLite persistence: after two quick writes to one row, the collection briefly shows the state before the second write

Đã đóng
  • Có gì không ổn?
#2,201 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Một pull request liên quan đã được merge.

  • #2208 của @KyleAMathews — đã merge

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
48/100
Loại issue
Lỗi
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
sqlite, typescript
Lĩnh vực
database, databases

Hướng nghiên cứu

Start with the persistence and transaction flow described in the issue, especially awaitTxId, applyMutex, pendingSyncedTransactions, and recomputeOptimisticState; the linked reproduction and its README contain the trace and timings. Trace how an update is handled while SQLite still stores the insert's synced transaction, then verify that the collection never shows an older state after awaitTxId resolves. The issue does not identify source files or tests, so locating the relevant code and adding a regression test will take familiarity with the project.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

  • I've validated the bug against the latest version of DB packages

Describe the bug

An Electric collection with persistedCollectionOptions inserts a row and updates it right away. Both handlers await awaitTxId. After the update is confirmed, the collection shows the pre-update state for 10–30 ms, then the updated state again. Without persistence, this never happens.

I hit this in a shopping list app. A user adds an item and ticks it off. The tick disappears for a moment, then comes back. An action that runs during that gap reads the old state: "clear bought items" saw the item as not bought and left it on the list. With 10× CPU throttling, the gap reached 263 ms in my app.

To Reproduce

Repro: https://github.com/daniel-fahl/tanstack-db-flicker-repro (StackBlitz). It needs no backend: a fake Electric server runs in the page.

  1. Open the repro.
  2. Click Add and tick 30 times. Each run inserts a todo and updates done to true without waiting in between.
  3. See the result: 30 of 30 runs flicker. Each run logs the states the collection showed, for example missing → unticked → ticked → unticked +24 ms → ticked +41 ms.
  4. Switch to Control (?persistence=off) and run again: 0 of 30 flicker.

Expected behavior

When awaitTxId(txid) resolves and the handler returns, the collection never shows a state older than that write.

Screenshots

None. The repro's log shows every state with its timing.

Desktop (please complete the following information):

  • OS: macOS; my app's CI also hits it on Ubuntu (GitHub Actions ubuntu-latest)
  • Browser: Chromium, via Playwright
  • Version: Chromium as bundled with @playwright/test 1.64

Smartphone (please complete the following information):

Not tested on a device yet. 10× CPU throttling stands in for a slow phone.

Additional context

Versions: @tanstack/db 0.15.1, @tanstack/electric-db-collection 0.6.2, @tanstack/browser-db-sqlite-persistence 0.2.36, @tanstack/offline-transactions 1.1.3, @electric-sql/client 1.5.28. The same result on @tanstack/db 0.15.0 with @tanstack/electric-db-collection 0.6.1, and on 0.13.0 with 0.5.9.

Cause, in brief: the update's txid arrives while SQLite still stores the insert's synced transaction. awaitTxId resolves, but the update's synced transaction waits for applyMutex, so it is not in pendingSyncedTransactions yet. When onUpdate returns, recomputeOptimisticState finds no committed pending synced transaction for the key and drops the optimistic row. The repro's README has the full trace with timings from my app.

Possible fix: I am not sure where it belongs. Two ideas:

  • awaitTxId resolves only once the synced transaction for that txid has reached the collection, at least as a committed pending transaction.
  • recomputeOptimisticState also keeps the optimistic row while a synced transaction for that key still waits on persistence.

Waiting until the rows are fully applied would deadlock: the collection holds back synced rows while a transaction is persisting, and the handler's own transaction is persisting while it awaits the txid.

My workaround: the handler waits 150 ms after awaitTxId resolves. That was the shortest wait that removed every flicker in my app at 10× CPU throttling.

Related: #2120 may be related. It covers changes that progressive mode applies and confirms during the background full sync.

Ngôn ngữ chính
TypeScript
Star
3.9k
Fork
277
Merge trung bình
18 giờ 12 phút
Pull request đã merge (30 ngày)
229

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của TanStack/db

Tất cả issue của TanStack/db

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.