Hacktoberfest 2026: những issue maintainer đã đánh dấu cho tháng Mười, đang mở và phù hợp người mới. Xem issue Hacktoberfest

ai, ai-persistence: a nested subagent that waits runs again from the start under withPersistence

Đang mở
  • Có gì không ổn?
#1,878 0 bình luận 0 reaction 1 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

@tombeckenham đang làm issue này rồi.

Từ ngày 22/10/2026.

Đánh giá

Issue này chưa được đánh giá.

Mô tả

waiting-on: maintainer
TanStack AI version

@tanstack/ai and @tanstack/ai-persistence on main, after #1806.

Framework/Library version

Node 24.8.0. Server only.

Describe the bug and the steps to reproduce it

Under withPersistence, a nested subagent that waits on an interrupt runs again from the start after the resume.

Since #1806, a waiting child resumes from loadChild(...).pending, the stored messages, not from the client card. The store keeps a nested child in its own thread (subagent:<id>). So the pending of the outer child has its tool call, but no card for the nested child that waits. Core then finds no suspended child inside the outer child (readSubagentTurn in agents/turn.ts), and runs the nested child again.

Steps:

  1. A lead agent calls a researcher agent tool. The researcher calls a writer agent tool. The writer calls write_file, which needs approval.
  2. Run the turn. It stops on the writer's approval.
  3. Resolve the approval.
  4. The writer runs again from its prompt. write_file does not run. A real model asks for the approval again.

packages/ai-harness/tests/subagent-waits.test.ts "waits for an agent that an agent tool calls, and both go on" on feat/harness-core fails on this.

A quick fix copies the nested cards from the client onto the stored message. That trusts the client's messages for the nested child, which #1806 closed one level up: a forged card can change the args of the nested tool call before the approval runs it. Do not ship that.

Fix design: the card is a pointer, the store gives the contents
  1. LoadChild takes an optional parent (packages/ai/src/activities/chat/middleware/load-child.ts): (subagentRunId, options?: { parentSubagentRunId?: string }). The result also gets interruptIds? and parentToolCallId?, read from the stored info, so the card is not the source.
  2. withPersistence passes the parent on (packages/ai-persistence/src/middleware.ts, provideLoadChild): with a parent, the caller is { threadId: ctx.threadId, subagentRunId: parentSubagentRunId }. The existing check in loadChild (marker.parentThreadId !== ownerThread(caller)) proves that the nested child belongs to that parent. Core asks for a nested child only after it loaded the parent, so the chain is checked from the top.
  3. loadChild returns interruptIds and parentToolCallId (packages/ai-persistence/src/subagent-runs.ts), from storedSubagentInfo.
  4. Core rebuilds nested cards from the store (packages/ai/src/activities/chat/agents/spawn.ts, runChild): for each card subagent part whose parentToolCallId is a tool call in the stored pending, call load(id, { parentSubagentRunId }). No pending means throw "not waiting", as the top level does. Build the part from the store: messages from pending, interruptIds, parentToolCallId, status: 'suspended'. Take only the id from the card. Repeat for deeper nesting.

The LoadChild change is additive. A loader that ignores the parent fails closed for nested children.

Tests:

  • The nested resume: write_file runs once after the approval, and the writer model is called twice.
  • A nested card with changed write_file args does not change what runs (like the #1806 forged-card test, one level down).
  • A nested card that names a child of another parent throws "not waiting".

Docs: the pending line in docs/chat/subagents.md. Add a changeset.

Your Minimal, Reproducible Example - (Sandbox Highly Recommended)

packages/ai-harness/tests/subagent-waits.test.ts on feat/harness-core, test "waits for an agent that an agent tool calls, and both go on". The same three-level setup works with plain chat() and withPersistence on main.

Do you intend to try to help solve this bug with your own PR?

Yes, I am already working on a fix

Terms & Code of Conduct
  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
Ngôn ngữ chính
TypeScript
Star
3.2k
Fork
372
Merge trung bình
1 ngày 16 giờ
Pull request đã merge (30 ngày)
244

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của TanStack/ai

Tất cả issue của TanStack/ai

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.