Hacktoberfest 2026: những issue maintainer đã đánh dấu cho tháng Mười, đang mở và phù hợp người mới. Xem issue Hacktoberfest

A background token refresh failure in a non-interactive process wipes every saved CLI session (all accounts)

Đang mở
  • Có gì không ổn?
#8,945 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 2 ngày

@efegokdemir đang làm issue này rồi.

Từ ngày 19/10/2026.

  • #8946 của @efegokdemir — đang mở

Đánh giá

Độ khó
5/5
Thời gian dự kiến
Hơn một tuần
Mức phù hợp với người mới
35/100
Loại issue
Lỗi
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
typescript
Lĩnh vực
authentication, cli

Hướng nghiên cứu

Start with packages/cli-kit/src/private/node/session.ts, especially throwOnNoPrompt() and the refresh paths, then read packages/theme/src/cli/utilities/theme-environment/dev-server-session.ts to see how refresh failures are handled. Reproduce the reported behavior with concurrent shopify theme dev processes and inspect the shared config.json. Done means a refresh failure no longer removes unrelated saved sessions, concurrent refreshes do not overwrite valid session data, and users can see when theme dev loses its session.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Summary

When a long-running CLI process (e.g. shopify theme dev) hits a refresh failure while running with noPrompt: true, throwOnNoPrompt() calls logout(), which removes the entire session store (sessionStore + currentSessionId) from config.json, for every account and alias. Because the theme dev auto-refresher swallows the error (outputDebug('Session could not be refreshed.')), nothing is shown to the user. The next CLI command in any terminal then asks for a full login.

On a machine that runs several CLI processes at the same time, this makes the CLI feel like it "expires" every few hours.

Environment
  • Shopify CLI 4.9.4 (Homebrew), macOS, Apple Silicon
  • Several shopify theme dev processes for different stores running at the same time, plus one-off CLI commands from scripts/other terminals, all sharing the same ~/Library/Preferences/shopify-cli-kit-nodejs/config.json
Observed
  • While two shopify theme dev processes were running, config.json ended up with only the cache key; sessionStore and currentSessionId were gone.
  • The theme dev terminals showed no error. The next command in another terminal required a full device login.
Relevant code (main @ 060e88b)
  1. throwOnNoPrompt() logs out before it throws, so one non-interactive process failing removes the sessions every other process relies on:
    https://github.com/Shopify/cli/blob/060e88b3b9d8c6ca01dfa50bbb442ce6470060e2/packages/cli-kit/src/private/node/session.ts#L298-L307
    It is reached from both needs_full_auth and InvalidGrantError during refresh:
    https://github.com/Shopify/cli/blob/060e88b3b9d8c6ca01dfa50bbb442ce6470060e2/packages/cli-kit/src/private/node/session.ts#L252-L271
  2. The theme dev auto-refresher runs every 30 minutes with noPrompt: true and swallows failures:
    https://github.com/Shopify/cli/blob/060e88b3b9d8c6ca01dfa50bbb442ce6470060e2/packages/theme/src/cli/utilities/theme-environment/dev-server-session.ts#L56-L63
  3. The session store is read, modified and written back as a whole. I couldn't find any cross-process lock around it:
    https://github.com/Shopify/cli/blob/060e88b3b9d8c6ca01dfa50bbb442ce6470060e2/packages/cli-kit/src/private/node/session.ts#L273-L284
Suspected trigger (not confirmed)

Two processes refresh at around the same time using the same refresh token, or one overwrites the store with stale tokens after the other has refreshed. If refresh tokens are rotated, the later refresh gets invalid_grant, which goes through throwOnNoPrompt(), which wipes all sessions. I couldn't confirm whether Identity rotates refresh tokens, but the "one failure clears everything" behaviour comes straight from the code above, whatever causes the refresh to fail.

Steps to reproduce (likely)
  1. shopify auth login
  2. Start shopify theme dev against two different stores in two terminals and leave them running for a few hours (past the access-token expiry, so the 30-minute auto-refresher has to refresh).
  3. Check config.json: sessionStore disappears at some point, and the next CLI command asks for a full login.
Expected
  • A refresh failure in one non-interactive process should not delete sessions for other processes or accounts. At most it should fail that process, or invalidate only the session it was using.
  • Concurrent refreshes should be serialized (file lock), or the store should be re-read before writing, so that processes don't invalidate each other's tokens.
  • When theme dev loses its session, the user should see it in the terminal instead of a debug-only log line.
Related

#5826 and #3173 report similar "randomly signed out / unable to prompt for reauthentication" symptoms. Both were closed after fixes to single-process error handling. The multi-process case doesn't seem to be covered.

Ngôn ngữ chính
TypeScript
Star
763
Fork
295
Merge trung bình
4 ngày 12 giờ
Pull request đã merge (30 ngày)
175

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của Shopify/cli

Tất cả issue của Shopify/cli

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.