Enhance interpolation speed

Đang mở
#1,145 0 bình luận 0 reaction 1 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 3 ngày

@steven-murray đang làm issue này rồi.

Từ ngày 15/2/2022.

Đánh giá

Issue này chưa được đánh giá.

Mô tả

beams enhancement HERA

There are a lot of checks that are done in the interpolation methods, some of which are more compute-intensive than others. For example, #1144 adds the ability to skip one of these checks.

Furthermore, calling eg. _interp_az_za_simple always creates the phi_use and theta_use arrays, even when they are not required because the interpolation functions have already been computed and stored. This is not hugely computationally expensive, but does give an estimated ~30% slowdown compared to just calling the saved spline directly (this number was something I noticed for a single use case, so is highly subject to uncertainty/variability).

There may be ways to deal with this a bit more intelligently. Some examples:

  1. Let the interp() function to know ahead of time if these arrays need to be computed. However, this is a bit tricky because it's not a single spline that's created, but multiple splines (for each pol/spw/feed/freq), and while one may be stored, others that are requested may not be. We'd then have to put in a little check for that.
  2. Another way would be to have documentation/methods that allow directly calling the saved interpolations without any other checks, at the user's own peril.
  3. Another way would be to refactor the existing interpolation private methods to call a function that returned the interpolators themselves, and then used those to interpolate to the new az/za. This new intermediate function could then be called by users to save copies of the interpolation functions in whatever way they choose, to be called in any way they choose.

There might be other ways as well.

Having written this down, my vote would be to do something like (2) -- have an explicit method called something like "az_za_simple_fast" that just assumes the splines have been computed before and goes and uses them, and errors if they're not there. This could be called from interp() if a parameter like no_checks is set.

Ngôn ngữ chính
Python
Star
103
Fork
40
Merge trung bình
4 ngày 11 giờ
Pull request đã merge (30 ngày)
13

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của RadioAstronomySoftwareGroup/pyuvdata

Tất cả issue của RadioAstronomySoftwareGroup/pyuvdata

Issue tương tự

Thêm issue về Python

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.