Hacktoberfest 2026: những issue maintainer đã đánh dấu cho tháng Mười, đang mở và phù hợp người mới. Xem issue Hacktoberfest

Provide an API to resolve, verify and load the datasets .py certifies

Đang mở
#667 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
5/5
Thời gian dự kiến
Hơn một tuần
Mức phù hợp với người mới
25/100
Loại issue
Tính năng
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
python

Hướng nghiên cứu

Start by reading policyengine/bundle.py, policyengine/provenance/manifest.py, policyengine/provenance/dataset_materialization.py, and the related issues #270, #502, #415, and #591. Trace how bundle pins, release records, dataset verification, and managed_microsimulation work today, then decide how the proposed API should cover the open questions. Done means a documented API exposes the agreed capabilities with typed errors and tests for verification, mismatches, caching, and loading.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

enhancement low-priority

Problem

.py's bundle manifest (policyengine/data/bundle/manifest.json) records, for each country, the certified data release (repository, revision, files and their sha256) and the exact country-package versions each extra pins. Repos that run models on that data keep re-deriving this information in their own code instead of asking .py for it.

The clearest example is calibration-diagnostics, which moved to policyengine[us]==6.4.1 in PolicyEngine/calibration-diagnostics#222. frontend/scripts/hosted_release.py implements:

  • certifying_package: reads the .py version and extra that a checked-in hosted_release.json names as the certifier. That file repeats the release ID, Hugging Face commit, file name, sha256 and package versions.
  • py_pinned_packages: parses the installed .py distribution's Requires-Dist entries and evaluates the extra markers to get the exact policyengine-us, policyengine-core and spm-calculator versions.
  • py_bundle_manifest: opens policyengine/data/bundle/manifest.json by path through importlib.metadata.
  • validate_py_certification: matches the release ID, data build ID, dataset sha256 and URI, repository, release and build manifest paths, revision, model version and every file digest against data_releases["us"].
  • download_certification and verify_h5: download the release manifest, build manifest and H5 with huggingface_hub, then hash them.

verify_hosted_runtime.py and generate_variable_catalog.py use these functions. The same repo's evaluation harness, in evaluation_harness/adapters/microcosm.py, hard-codes the same release ID and sha256 a second time and has its own download and sha256 check.

Other repos do similar work:

  • policybench, policyengine_runtime.py: matches Requires-Dist with a regex to find the model pin, and reads the manifest by path, with a fallback for the per-country manifest files that 4.x shipped.
  • obbba-household-by-household, export_microcosm_explorer.py: reads data_releases["us"] by path.
  • policyengine-sim-api, release_bundle.py: walks the raw dict from get_current_bundle() for package versions, dataset URIs and digests.
  • uk-triple-lock, datasets.py: hard-codes release manifest and dataset digests, with its own download, hashing and DatasetMismatch error.
  • uk-autumn-budget-dashboard-2026, bundle_adoption.py: reads data_releases["uk"]["certified_data_artifact"]["sha256"].

All of these depend on the manifest's internal layout, which has already changed once (from per-country manifests in 4.x to data_releases in 6.x). Each also needs a manual edit whenever .py certifies a new release.

What .py already provides

Most of the building blocks exist, and all of the following were already in 6.4.1:

None of the consumers above uses these for the whole flow. These gaps send them back to their own code:

  • Verifying a local file. There is no public way to check a file the caller already has (from the Hugging Face cache, or a --dataset-file argument) against the certified sha256 without downloading it again. _reuse_or_download_bundle_files is private, and it replaces a mismatching file rather than refusing it. A local path passed to materialize_dataset or managed_microsimulation needs allow_unmanaged=True, and then loses its certified identity (bundle_dataset is None).
  • Failing on a version mismatch. No function raises when the installed environment differs from the pins. inspect_bundle_status returns dicts, and the country model version only emits a UserWarning when the installed country package differs from the pin.
  • Checking a release. No call answers "does this .py certify this repository, revision and sha256?". Consumers compare the fields themselves.
  • Pins as a mapping. Pins are available as requirement strings or as the raw packages and extras blocks, but not as a {package: version} mapping for one extra.
  • Manifest identity. The bundle records no digest for the US release_manifest.json, and the US revisions are tag names (populace-us-2024-spm-20260915), not commit SHAs. calibration-diagnostics therefore pins the commit (8ab57ffc…, which the tag currently resolves to) and its own manifest digests.
  • Cache location. materialize_dataset defaults to ./data, relative to the working directory.
  • Error types. Errors are BundleError, DatasetMaterializationError, DataReleaseManifestUnavailableError or plain ValueError, all ValueError subclasses. A version mismatch, a digest mismatch and an unknown dataset can be told apart only by their messages.

Proposed functionality

This is a list of capabilities, not a fixed design. One documented module that builds on the code above would cover it:

  • List the datasets certified for a country.
  • Get a certified release's identity: repository, repository type, revision (tag and commit), file path, sha256, and the release and build manifests with their digests.
  • Get the exact country-package versions the installed .py pins for an extra, as a mapping.
  • Verify the installed environment against those pins, and raise on mismatch.
  • Check whether a given repository, revision and sha256 is a release this .py certifies.
  • Download a certified dataset or release file, with digest verification and caching in a user cache directory or the Hugging Face cache.
  • Verify a local file against a certified record without downloading it, and keep its certified identity.
  • Load a verified file into a simulation through the same path as managed_microsimulation, so the stored-input renames and SPM handling apply.
  • Raise typed errors on mismatch, such as a package version mismatch, a dataset digest mismatch or an uncertified dataset.
  • Optionally, a CLI equivalent (for example policyengine bundle verify --dataset-file …) for image builds.

Why it helps

The certified release would have one source of truth. Consumers would stop copying release IDs and digests into their own JSON and constants, and would stop depending on the manifest's layout. An upgrade would then mean bumping .py in each repo. calibration-diagnostics alone could drop most of hosted_release.py, hosted_release.json and the release constants in its harness.

Priority

Low; this is a nice-to-have. Nothing is blocked, and the consumers above work today with their own code.

Open questions

  • Private datasets and authentication: the UK default lives in policyengine/policyengine-uk-data-private. Should the API accept a token argument as well as HUGGING_FACE_TOKEN, and report which credential it needs before it starts a download?
  • Offline use: should verifying and loading work without network access when the files are already local? This includes the release manifest that get_data_release_manifest currently fetches.
  • Revisions and digests: should the bundle record a commit SHA for each artifact, as it already does for the UK release manifest revision, plus a digest of each release manifest?
  • JSON digests: should the JSON manifests be identified by byte sha256 (what .py records) or by a canonical-JSON digest (what calibration-diagnostics records)?
  • Historical bundles: should the API also read older bundles through load_bundle_manifest(version), so a consumer can check a release that an earlier .py certified?
  • First adopters: which consumers would adopt this first? calibration-diagnostics (hosted runtime and harness) and policybench look like the smallest changes.

Related: #270 (the manifest layer), #502 (unified dataset materialization), #415 (local files in managed_microsimulation) and #591 (year-file identity).

🤖 Generated with Claude Code

Ngôn ngữ chính
Python
Star
8
Fork
10
Merge trung bình
23 giờ 16 phút
Pull request đã merge (30 ngày)
49

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của PolicyEngine/policyengine.py

Tất cả issue của PolicyEngine/policyengine.py

Issue tương tự

Thêm issue về Python

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.