Hacktoberfest 2026: những issue maintainer đã đánh dấu cho tháng Mười, đang mở và phù hợp người mới. Xem issue Hacktoberfest

Startup does not verify the database schema matches the code

Đã đóng
  • Có gì không ổn?
#352 3 bình luận 0 reaction 1 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 3 ngày

@titankrypt-gif đang làm issue này rồi.

Từ ngày 16/10/2026.

  • #463 của @sparkysolutions10-pixel — đang mở
  • #537 của @sparkysolutions10-pixel — đang mở
  • #553 của @titankrypt-gif — đang mở

Đánh giá

Issue này chưa được đánh giá.

Mô tả

area:database difficulty:advanced help wanted points:200 Stellar Wave
Background

prisma/ contains only schema.prisma — there is no migrations/ directory,
so every schema change this project has made has been a prisma db push. That
means there is no record of which schema version is deployed and no check at
startup that the database matches what the code expects.

The failure mode is a process that starts cleanly and then fails on the first
query touching a column that does not exist — at request time, in production,
on one instance of several if a deploy is partial.

What to build
  • A startup check that the schema the code expects is actually present, failing
    fast and naming what is missing.
  • Report schema readiness through /ready (L168) so an instance with a stale
    database never receives traffic.
  • Write down, in docs/, why there are no migrations and what the intended path
    is — adopting Prisma Migrate is a larger decision than this issue, but the
    current state should be a recorded choice rather than an accident.
Acceptance criteria
  • Startup fails fast and names the problem when the database does not match the schema
  • /ready reflects schema readiness
  • The check is cheap enough to run on every boot
  • The absence of a migrations directory is documented with its rationale
  • A test covers the mismatch case

Drips Wave · Complexity: Advanced · 200 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Ngôn ngữ chính
TypeScript
Star
4
Fork
71
Merge trung bình
3 ngày 10 giờ
Pull request đã merge (30 ngày)
154

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của Divinity-Labs/Lens

Tất cả issue của Divinity-Labs/Lens

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.