Nothing proves a deployed instance can actually answer

Đã đóng
  • Có gì không ổn?
#346 2 bình luận 0 reaction 1 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 4 ngày

@krsnak đang làm issue này rồi.

Từ ngày 16/10/2026.

  • #355 của @krsnak — đang mở
  • #481 của @sparkysolutions10-pixel — đang mở

Đánh giá

Issue này chưa được đánh giá.

Mô tả

area:testing difficulty:intermediate help wanted points:150 Stellar Wave
Background

CI runs unit tests against mocks. Nothing checks that a running Lens answers
correctly — that /price returns a number with the right shape, that /status
is healthy, that the websocket accepts a subscription and pushes an update.

The failures in this batch are precisely the ones unit tests cannot catch: a
hung fetch, a dead ingester, an exhausted pool. All of them leave the process up
and the tests green.

What to build

A smoke check that runs against a URL and exits non-zero on failure:

  • /status and /ready report healthy.
  • /price for a known pair returns a well-formed response within a time budget.
  • The websocket accepts a connection, takes a subscription and delivers at least
    one message, or times out.
  • Prices are fresher than a threshold, not merely present.

It must take the base URL as an argument so it works against local, staging and
production, and it must not require credentials beyond what a normal caller has.

Acceptance criteria
  • A single command runs the smoke check against any base URL
  • It exits non-zero on any failure and prints which check failed
  • It asserts freshness, not just presence
  • It covers at least one websocket round-trip
  • It runs in well under a minute and is documented in the README

Drips Wave · Complexity: Intermediate · 150 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Ngôn ngữ chính
TypeScript
Star
4
Fork
71
Merge trung bình
3 ngày 22 giờ
Pull request đã merge (30 ngày)
142

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của Divinity-Labs/Lens

Tất cả issue của Divinity-Labs/Lens

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.