Template tests assume core comes from the monorepo source and fail in a scaffolded workspace

Đang mở
#8,331 1 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
48/100
Loại issue
Lỗi
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
node.js, typescript
Lĩnh vực
testing, tooling

Hướng nghiên cứu

Start with the template Vitest configs and the failing specs named in the report: server/mcp-provider-schemas.spec.ts, server/plugins/identity-sso.spec.ts, and server/actions/connection-permissions.spec.ts. Check how they resolve @agent-native/core and mock paths in both the monorepo and a scaffolded workspace; the report also identifies 94 test files across 13 templates that reference ../packages/core/. Done means the affected template tests pass in a workspace created from packed packages as well as in the monorepo.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Environment: multi-app workspace (chat and dispatch) created with agent-native create, core 0.220.0 installed from npm, apps synced to @agent-native/[email protected] with agent-native template sync, vitest 4.1.12, Node 24.20. The code is unchanged on main at 3a7038f2ea.

What happens: pnpm test in the apps:

  • chat and dispatch: server/mcp-provider-schemas.spec.ts fails before running any test:
    FAIL  server/mcp-provider-schemas.spec.ts > Chat MCP catalogs
    Error: Cannot find module '.../apps/chat/actions/hello' imported from .../apps/chat/.generated/actions-registry.ts
    
  • dispatch: 3 of the 41 tests in server/plugins/identity-sso.spec.ts fail with TypeError: Cannot read properties of undefined (reading 'headers').
  • dispatch: all 13 tests in server/actions/connection-permissions.spec.ts fail with relation "org_members" does not exist.

Why: in the monorepo the templates depend on "@agent-native/core": "workspace:*", so core resolves to packages/core, outside node_modules, and I believe Vitest transforms it like project code. In a scaffolded workspace core lives in node_modules, so Vitest externalizes it and Node loads it directly. Adding test.server.deps.inline: [/@agent-native[\\/]core/] to the app's Vitest config makes the first two failures go away. Then:

  1. loadTemplateMcpConformance (packages/core/src/mcp/provider-schema-conformance.ts:570) loads .generated/actions-registry.ts through the default loader, a native import() (:492). The registry imports actions without extensions (../actions/hello), which Node's ESM resolver rejects. Sixteen templates have this spec.
  2. identity-sso.spec.ts mocks h3 and @agent-native/core/* subpaths. My guess is that, with core externalized, those mocks don't reach the imports made from inside core.
  3. connection-permissions.spec.ts mocks ../../../../packages/core/dist/db/client.js, a path that only exists in the monorepo. In a workspace the mock never applies and the test reaches a database without the tables. calendar (calendar-mcp-writes.spec.ts) and factory (operation-executor-priming.spec.ts, operation-executor.core.spec.ts) mock the same kind of path. More broadly, git grep finds 94 test files in 13 templates that reference ../packages/core/ paths. I haven't checked them one by one, but any that mocks or imports through such a path should break the same way in a workspace.

Workaround:

  • For (1) alone, inline just the loader in the app's vitest.config.ts; with it, all 15 test files in chat pass:
    test: {
      server: {
        deps: {
          inline: [
            /@agent-native[\\/]core[\\/]dist[\\/](testing|mcp[\\/]provider-schema-conformance)\.js$/,
          ],
        },
      },
    },
    
  • Inlining all of core (/@agent-native[\\/]core/) also fixes (2). (3) has no config workaround.

Possible fix:

  • Have the templates' vitest.config.ts inline @agent-native/core, so the tests run the same way in the monorepo and in a workspace.
  • Mock core internals through a path that resolves in both layouts instead of ../../../../packages/core/....
  • Running the template tests in a workspace scaffolded from the packed packages would catch this class of bug, along with #8239 (happy-dom resolved only through the monorepo, fixed in #8279).
Ngôn ngữ chính
TypeScript
Star
7.7k
Fork
706
Merge trung bình
1 ngày 11 giờ
Pull request đã merge (30 ngày)
790

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của BuilderIO/agent-native

Tất cả issue của BuilderIO/agent-native

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.